Repository navigation
Conversation
geonnave
force-pushed
the
spin-append-placed-hint
branch
from
October 15, 2026 11:26
fdc741e to
2e725fe
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
==========================================
+ Coverage 88.56% 88.57% +0.01%
==========================================
Files 230 230
Lines 37623 37650 +27
Branches 2367 2367
==========================================
+ Hits 33319 33347 +28
+ Misses 4300 4299 -1
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This was referenced Oct 15, 2026
geonnave
force-pushed
the
spin-append-placed-hint
branch
5 times, most recently
from
October 16, 2026 14:07
702a0ff to
018521f
Compare
AI-assisted: Claude Opus 5.5
… a placed one AI-assisted: Claude Opus 5.5
geonnave
force-pushed
the
spin-append-placed-hint
branch
from
October 16, 2026 14:38
018521f to
9ddf837
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on main. #344 (
place --to-calibration) stacks on this one.Problem
calibrate-lh2 collect --spin --append IDrightly refuses a calibration already placed on a site (its frame is the site's, and a re-solve would not keep it), but the error only said "append to the spin calibration it was made from", leaving the operator to find which one. On the bench that meant reading anchors by hand, and the anchor can mislead: a calibration aligned into asite initsite carries that site's anchor, which names the site's original spin calibration, not the one it was actually moved from.Change
placed_from = "<id>"in[metadata]: the full id of the free-frame calibration it came from.site initsets it. It is outside the id hash, liketag, since it moves no position....: it was placed from spin calibration 4414d748, so append to that one (--append 4414d748 --site virmond-rooms).placed_from; for those theself-defined from spin calibration <id8>anchor thatsite initwrites is the fallback, worded as "its site was defined from spin calibration ..." since that is all it proves.show --next-roundshares the check, so it gets the same message.Validation
Unit, both through the CLI with a faked swarm: a
site init-placed calibration refused with the source id and--site c405, and nothing sent to the robots; the same file withplaced_fromstripped falls back to the anchor. Full suite: 1789 passed, 2 failed that fail identically on the base commit in this environment (test_camera_service::test_a_registration_without_controls_warns_about_nothing, andtest_controller_dotbot_simulator, which could not bind its port). Not run on hardware. Formatting is deferred to the pass after review.dotbot/tests/test_calibration_spin.pydotbot/calibration/multi_station.pydotbot/calibration/lighthouse2.pydotbot/calibration/conics.py