Skip to content

Add Linting - #14

Merged
wardvp merged 12 commits into
mainfrom
add-ci-pep8
Nov 6, 2025
Merged

wardvp merged 12 commits into
mainfrom
add-ci-pep8

Conversation

@BenjaminRodenberg

Copy link
Copy Markdown
Collaborator
  • Introduces linter for PEP8 compliance and more uniform formatting

@BenjaminRodenberg BenjaminRodenberg self-assigned this Nov 5, 2025
@BenjaminRodenberg
BenjaminRodenberg marked this pull request as ready for review November 5, 2025 17:19
@BenjaminRodenberg BenjaminRodenberg mentioned this pull request Nov 5, 2025
4 tasks done

@BenjaminRodenberg BenjaminRodenberg left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wardvp Can you review this PR?

These are really a lot of changes because I applied a linter for more uniform code formatting. I think for the review there are two categories of changes:

  1. Most of the changes are trivial. If you quickly look over the diff here you can check if you like the general style. If you have some preference, please let me know (E.g. maximum line length). I think the default rules are usually good and it is just important to have some kind of rule for consistency. Let's try to not invest too much time here.
  2. I had to apply some manual changes where the automatic linter cannot decide. Please refer to the history here. Basically all commits after db12295 are not trivial and I did not want these changes to get lost in the noise. If there is something you do not like, please let me know (you can comment in the diff). Again: I tried to be minimally invasive.

Finally: Since it's only "cosmetics" the behavior of the code should not change. But maybe some syntax error manages to sneak in. If you can do some minimal tests to make sure I did not introduce a runtime error that would be helpful. I only ran the example case manually and this worked (up to the expected point).

@wardvp wardvp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quickly scanned this and it looks good to me. I have not tested the new code yet, but will do so in a bit. If all is fine I will approve the changes.

@wardvp

wardvp commented Nov 6, 2025

Copy link
Copy Markdown
Collaborator

It runs without issues, so I will now press "Merge pull request"

@wardvp
wardvp merged commit 4bc933f into main Nov 6, 2025
2 checks passed
@BenjaminRodenberg
BenjaminRodenberg deleted the add-ci-pep8 branch November 6, 2025 10:59
@wardvp
wardvp restored the add-ci-pep8 branch November 6, 2025 14:25
@BenjaminRodenberg BenjaminRodenberg added this to the First Release milestone Nov 11, 2025
@BenjaminRodenberg
BenjaminRodenberg deleted the add-ci-pep8 branch January 9, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants