Repository navigation
Add Linting - #14
Add Linting#14
Conversation
BenjaminRodenberg
commented
Nov 5, 2025
- Introduces linter for PEP8 compliance and more uniform formatting
* Expected to fail
* black cannot fix this automatically.
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
@wardvp Can you review this PR?
These are really a lot of changes because I applied a linter for more uniform code formatting. I think for the review there are two categories of changes:
- Most of the changes are trivial. If you quickly look over the diff here you can check if you like the general style. If you have some preference, please let me know (E.g. maximum line length). I think the default rules are usually good and it is just important to have some kind of rule for consistency. Let's try to not invest too much time here.
- I had to apply some manual changes where the automatic linter cannot decide. Please refer to the history here. Basically all commits after db12295 are not trivial and I did not want these changes to get lost in the noise. If there is something you do not like, please let me know (you can comment in the diff). Again: I tried to be minimally invasive.
Finally: Since it's only "cosmetics" the behavior of the code should not change. But maybe some syntax error manages to sneak in. If you can do some minimal tests to make sure I did not introduce a runtime error that would be helpful. I only ran the example case manually and this worked (up to the expected point).
wardvp
left a comment
There was a problem hiding this comment.
I quickly scanned this and it looks good to me. I have not tested the new code yet, but will do so in a bit. If all is fine I will approve the changes.
|
It runs without issues, so I will now press "Merge pull request" |