Skip to content

Add work-arounds required for coupled run - #53

Merged
BenjaminRodenberg merged 7 commits into
mainfrom
ElmerXIOSrun-patch-1
Jan 19, 2026
Merged

BenjaminRodenberg merged 7 commits into
mainfrom
ElmerXIOSrun-patch-1

Conversation

@BenjaminRodenberg

@BenjaminRodenberg BenjaminRodenberg commented Dec 8, 2025 •

Copy link
Copy Markdown
Collaborator

This patch is required to successfully run our current version of the coupled test case with Elmer. The solutions should be considered as work-around solutions to be able to successfully perform a coupled run.

This includes the following two fixes:

Author's Todos

  • I ran the pre-commit hooks and fixed all issues
  • I added an entry under develop in the CHANGELOG.md (may be skipped for minor changes not obervable for the user)

Comment out the line that assigns grid['z'] from IN['h']
@BenjaminRodenberg BenjaminRodenberg self-assigned this Dec 8, 2025
@BenjaminRodenberg BenjaminRodenberg added the technical debt / maintainability fixing this issue will make our lives easier in future label Dec 8, 2025
@BenjaminRodenberg
BenjaminRodenberg marked this pull request as draft December 8, 2025 13:09
Comment thread src/main.py Outdated
@BenjaminRodenberg

Copy link
Copy Markdown
Collaborator Author

Some of the latest changes in main require further (temporary) modifications.

I'm using the branch ElmerXIOSrun-patch-2 for debugging. Note that this branch includes some changes that are not yet merged into main. Therefore, I would suggest to keep our current baseline at 2f207b7.

@BenjaminRodenberg BenjaminRodenberg added this to the v0.2.0 milestone Jan 15, 2026
@BenjaminRodenberg
BenjaminRodenberg marked this pull request as ready for review January 15, 2026 15:57
@BenjaminRodenberg

Copy link
Copy Markdown
Collaborator Author

I found some places where the generalizations in #12 and #57 did not apply. I reverted the respective changes as a work around. Still needs some testing.

I would like to merge this PR soon because main and baseline have diverged quite a bit. We can try to find a better solution later.

@matthias-ibach

Copy link
Copy Markdown
Collaborator

I checked this branch and could successfully run it with our testcase (run_elmer_ebfm_coupling.sh).

@ClemensSchannwell Could you please confirm and check whether you can run this branch with the testcase as well? This way, we could bump up the baseline version and fix some issues.

@BenjaminRodenberg BenjaminRodenberg changed the title Comment out grid assignment from IN['h'] Minor work-arounds for coupled run Jan 19, 2026
@BenjaminRodenberg BenjaminRodenberg changed the title Minor work-arounds for coupled run Add work-arounds required for coupled run Jan 19, 2026
@ClemensSchannwell

Copy link
Copy Markdown
Collaborator

I can confirm that this branch works with our testcase.

@BenjaminRodenberg
BenjaminRodenberg merged commit f2cd676 into main Jan 19, 2026
6 checks passed
@BenjaminRodenberg
BenjaminRodenberg deleted the ElmerXIOSrun-patch-1 branch January 19, 2026 19:09
@BenjaminRodenberg

Copy link
Copy Markdown
Collaborator Author

Merged this PR. I also shifted the tag baseline to point to the latest state of main.

BenjaminRodenberg added a commit that referenced this pull request Jan 22, 2026
* Fix imports that were missed in #73
* Update to current interface of Coupler introduced in #65 overseen in merge of #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical debt / maintainability fixing this issue will make our lives easier in future

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants