Repository navigation
Remove unnecessary read_elmer_xios_grid - #57
Merged
Merged
Conversation
GridInputType.ELMER_XIOS does not allow for independent grid reading of the XIOS NetCDF. The XIOS NetCDF is always the DEM and comes with an additional Elmer grid.
BenjaminRodenberg
added
the
technical debt / maintainability
BenjaminRodenberg
changed the title
read_elmer_xios_grid
ClemensSchannwell
left a comment
ClemensSchannwell
left a comment
Collaborator
There was a problem hiding this comment.
I am sure that we can delete most of the stuff, but for some of the variables I am fairly sure, we will need them a little further down the line (e.g. grid["mask"]). And tbh I don't know the model well enough to be sure that it just happily computes stuff even though grid["mask"] is not allocated...
BenjaminRodenberg
left a comment
BenjaminRodenberg
left a comment
Collaborator
Author
There was a problem hiding this comment.
@ClemensSchannwell Thanks for the review. This helped a lot to identify the crucial parts. I modified the code to take care of your feedback.
2 of 3 tasks
1 of 2 tasks
BenjaminRodenberg
added a commit
that referenced
this pull request
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GridInputType.ELMER_XIOS does not allow for independent grid reading of the XIOS NetCDF. The XIOS NetCDF is always the DEM and comes with an additional Elmer grid.
This is a follow-up of #12
Author's Todos