Repository navigation
feat: open PDFs in tabs and check their signatures, through a MuPDF helper - #123
Merged
Merged
Conversation
This was referenced Oct 12, 2026
Merged
FPurchess
added this pull request to stack #126
October 12, 2026 18:44
FPurchess
force-pushed
the
feat/pdf-tab
branch
from
October 12, 2026 18:52
8866824 to
5d8eb3b
Compare
… PDF tabs, and say what the signature check found
… notices, and check it
… the focus in a list whose last entry goes
…what they and the client send each other, and take a signature's timestamp only from a token that holds
… on a busy machine
…g and building them every run
…gned again later, unchecked timestamps, weak SHA-1, timestamps required when asked
…tificate, and say plainly what signing does
…o compare, and document the signature check's new fields
…rints, and say why in plain words
…cus, the Sign dialog shows the date and the server, and says how the PDF was signed
… PDF, show a PDF without pages as damaged, and name Save's real key after a Word import
…and Cargo configuration its build reads
… Ubuntu no longer has webkit2gtk-driver
… blank-pdf is installed
…cus after Open again in PDF tabs
…nged or went, and offer Open again
…ichever the page and window give
…fter Close tab, and grey out what can't change a PDF, from the keyboard play-through
… instead of drawing it in full
…F that opens while a certificate is trusted, and check a PDF's signatures once per show
FPurchess
force-pushed
the
feat/pdf-tab
branch
from
October 13, 2026 06:58
5d8eb3b to
a8978aa
Compare
…into the PDF helper
# Conflicts: # .claude/rules/state.md # CLAUDE.md # scripts/build-notices.ts # src-tauri/Cargo.toml # src/editor/requests.ts # src/importers/docx/signatures.ts
…he test fixtures' line ends into CRLF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open PDFs in tabs and check their signatures. Stacked on #122 (
feat/signing); 3b (#124) builds on it.What users get
.pdflike any file. Its pages show read-only, with zoom, Print and the main menu. What doesn't apply to PDFs is greyed out, with the reason.view.signatureshas no default key; it can be bound in Settings.How it works
blank-pdfbuilt from MuPDF 1.28.5 (vendoredmupdf-sys; AGPL, compatible with Blank's AGPL-3.0-only), one helper per tab.PdfEnginetrait, so another renderer could replace MuPDF.bundle.externalBin; on Linux it's installed in/usr/lib/blank..github/actions/mupdf). Intel Macs are cross-built on PRs.verify) checks signatures. It guards against signature-wrapping and incremental-saving attacks, and caps the form walk..claude/rules/pdf.md,docs/guide/pdf.md, and the FAQ, files, install, menu, print and shortcuts pages.CONTRIBUTINGexplains the helper's build on a fresh machine.e2e/specs/pdf.e2e.tscovers opening a PDF, zoom, the signature status and Open again.First runs on CI
Checked by hand
/usr/lib/blank