Repository navigation
feat: fill in and sign PDFs you received, with found places, stamps and Next - #124
Merged
Merged
Conversation
This was referenced Oct 12, 2026
Merged
FPurchess
added this pull request to stack #126
October 12, 2026 18:44
FPurchess
force-pushed
the
feat/pdf-sign
branch
from
October 12, 2026 18:52
1fab8ca to
4991475
Compare
…'s box, and paint them and write their one-page PDFs from stamp engines
… a place, by its labels next to lines
…, dismissing and what filling each does
…in the pages or a field's appearance, empty fields for the other signers, one signing_sign_pdf with a plan and parts
…he date of signing, and rebuild the label fixtures from a script
…e fills as an update, in the PDF helper
…e the signer the filled bytes
…er the signature, and share the PDF's field types
…s on every page, a reason, and empty fields for the other signers of an export
…read what a PDF lets its signing tools place
…d resize them by keys and mouse, undo them, keep them in storage, and ask to sign before a PDF tab with stamps closes
…nd Sign…, the stamps in the rules, and an E2E case that places, nudges and undoes one
…go through them with Next, ask for the place, and sign it with Sign…
… in its signature field, Sign… with no digital signature
…the Sign dialog and what signed PDFs allow, in the guide, the shortcuts and the rules
…ping, not when Tab passes through it
…ld a refused fill was for, show choices by their display texts and check the glyphs MuPDF draws, fill tabs as spaces, drop the unused signatures op
…pression cap and once per signing, check the tab's file before reading its rules, keep repeated stamps' distance to the nearer edges, and a stamp's BBox where its content is
… by display text, the signer's refusals, caps and repeated stamps in the rules
…sed fill belongs to, and show repeated initials where the signer draws them
…mps to every file it opens, show locked and blocked fields disabled with their reason, and share the signing helpers
…hared fixtures, fix the label fixtures' boxes and precision, and bring the docs and rules up to date
…ake them smaller where they don't fit
… so a countersigned PDF says Signed by 2
… dates and places there in the letters of the line's label
…at shows again the focus
…signature as a picture, not signed
…ich Blank's target and the signature placed there cover
…t, and drop the Sign dialog's settings hint beside its initials button
…e field so it covers no other, and drop the docs' advice of a text stamp Blank doesn't have
…res Blank drew on them
…kip those checks on macOS and Windows, which lack them
…ning or putting the stamps back
…ed in its resources
…e, not signed only again
…tificate, as for exports
…open or has a Q too many
FPurchess
force-pushed
the
feat/pdf-sign
branch
from
October 13, 2026 06:58
4991475 to
754a4f5
Compare
# Conflicts: # .claude/rules/layout-engine.md # .claude/rules/state.md # src-tauri/layout/src/engine/select.rs # src-tauri/layout/src/items/signature.rs # src/engine/contract.test.ts # src/engine/pdf.ts # src/engine/wasm/blank_layout_bg.wasm
…ve the E2E job the pdftotext the PDF spec reads
…s and a signed export's
…he xpdf one Windows' runner has
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fill in and sign PDFs you received. Stacked on #123 (
feat/pdf-tab).What users get
pdf.next) goes through them in reading order. Enter or a click fills one. Places can be dismissed.How it works
stampEngine.ts). Its one-page PDF becomes a Form XObject in the page or in the field's appearance. The wasm is rebuilt.text,setFillsandsave, with the unusedsignaturesop removed. Each answer is held to its own request's limit.update_pdftakes a plan of stamps, a signature spot and others.rules.rsreads DocMDP and FieldMDP locks.signing_sign_pdftakes a JSON header plus the stamps' PDFs.places.ts/labels.tsfind the places.stampModel.tsholds the stamps, with one undo history of stamps, fills and dismissed places, kept understamps:<id>..claude/rules/pdf.md(with "Known limits") andsigning.md, plusdocs/guide/pdf.md,signing.md, the shortcuts and the FAQ.pdf.e2e.tsplaces, nudges and undoes a stamp, and signsform.pdfthrough Next, a typed signature and Sign….Decisions to review
Checked by hand