Repository navigation
fix: live E2E fixes for the 10-12 release (capture pill, network log, no-CORS images, identity race) - #180
Merged
Conversation
…s "Paused" The centred recording pill widened by the "Paused" label to both sides, so Resume jumped ~27px right of where Pause was clicked; clicking the same spot again hit the timer. The pill now grows to the left (centred and dragged pills); phones keep the full-width docked pill. Found in the live E2E of capture UI v2 (10-12). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ownloadable images, fix user-switch race - Network logs: the classic screenshot's own image/CSS XHRs were logged as the app's requests (a no-CORS image showed as "GET … FAILED", which Kai read). They are now marked internal and never recorded; the v2 DOM render's fetches (logger already paused) are also kept out of the Resource Timing entries. - v2 DOM screenshot: an <img> the browser render can't download (cross-origin without CORS) gets a neutral tint instead of an empty hole. - Identity: a /sessions answer for the cached contact that lands after Gleap.identify() switched the user no longer switches back (or clears the new contact); startFeedbackFlow / startClassicForm / startBot / startConversation / askAI wait for an identify in flight (max 5 s, like showSurvey) so the conversation isn't filed for the previous contact. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS SDK bug fixes from the overnight live E2E test of the 10-12 release, combined into one PR (report:
design-handoffs/e2e-live-2026-10-12/REPORT.md). Replaces:fix(capture): Pause/Resume stays under the pointer when the pill shows "Paused" #178: fix(capture): Pause/Resume stays under the pointer when the pill shows "Paused"
fix(capture): screenshot downloads out of network logs, tint no-CORS images, user-switch identity race #179: fix(capture): screenshot downloads out of network logs, tint no-CORS images, user-switch identity race
Recording pill (fix(capture): Pause/Resume stays under the pointer when the pill shows "Paused" #178): Pause/Resume stays under the pointer when the pill shows "Paused".
Network log (fix(capture): screenshot downloads out of network logs, tint no-CORS images, user-switch identity race #179): the SDK's own screenshot downloads are no longer logged as the customer's failed requests (Kai read them).
Cross-origin images (fix(capture): screenshot downloads out of network logs, tint no-CORS images, user-switch identity race #179): images without CORS now show as a neutral grey box in v2 screenshots instead of a hole (small visual choice, see
shots/capture-72-followup-nocors-placeholder.png). A full fix needs a server-side image proxy, not built.Identity race (fix(capture): screenshot downloads out of network logs, tint no-CORS images, user-switch identity race #179): a stale session answer can't switch back to the previous user, and start* / askAI wait for a running identify() (capped at 5 s); 4 regression tests.
Checks on the combined branch:
npm test528/528,npm run buildOK. Generatedbuild/andpublished/files are not committed. Needs an SDK release after merge; nothing released.🤖 Generated with Claude Code