Skip to content

refactor(installation): simplify terminal spawning logic - #25

Merged
newbe36524 merged 1 commit into
mainfrom
newclaude
Feb 26, 2026
Merged

newbe36524 merged 1 commit into
mainfrom
newclaude

Conversation

@newbe36524

@newbe36524 newbe36524 commented Feb 26, 2026 •

Copy link
Copy Markdown
Contributor

Remove platform-specific terminal handling and use unified approach with Claude CLI's built-in terminal management.

Summary by CodeRabbit

  • New Features

    • Added filePath field to LlmPromptConfig interface.
  • Refactor

    • Unified terminal spawning across all platforms into a single code path, reducing complexity and potential platform-specific inconsistencies.
    • Streamlined error handling for terminal operations.

Remove platform-specific terminal handling and use unified approach with Claude CLI's built-in terminal management.

Co-Authored-By: Hagicode <noreply@hagicode.com>
@coderabbitai

coderabbitai Bot commented Feb 26, 2026 •

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a741b5 and 4883c95.

📒 Files selected for processing (1)
  • src/main/llm-installation-manager.ts

📝 Walkthrough

Walkthrough

Consolidated platform-specific terminal spawning logic into a single cross-platform code path using direct CLI spawning. Removed platform branching for Windows, macOS, and Linux. Added filePath field to the LlmPromptConfig interface to expose the resolved prompt path. Net reduction of 48 lines.

Changes

Cohort / File(s) Summary
Terminal Spawning Consolidation
src/main/llm-installation-manager.ts
Unified platform-specific terminal spawning (Windows/macOS/Linux) into single cross-platform spawn call for Claude CLI. Removed exec and promisify imports. Simplified error handling and logging. Added filePath: string field to LlmPromptConfig interface.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Hops of joy through consolidated code,
Where platforms once split, now one single road,
No more branching paths, just Claude in the shell,
Spawn once, spawn true—simplicity's knell! 🌟

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch newclaude

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@newbe36524
newbe36524 merged commit 43ce3ac into main Feb 26, 2026
3 of 4 checks passed
@newbe36524
newbe36524 deleted the newclaude branch February 26, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant