Skip to content

refactor(installation): simplify terminal spawning logic #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
newbe36524 merged 1 commit into from
Feb 26, 2026
Merged

refactor(installation): simplify terminal spawning logic #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 14 additions & 62 deletions src/main/llm-installation-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
import fs from 'node:fs/promises';
import path from 'node:path';
import os from 'node:os';
import { exec, spawn } from 'child_process';
import { promisify } from 'util';
import { spawn } from 'child_process';
import log from 'electron-log';
import { Region, RegionDetector } from './region-detector.js';

const execAsync = promisify(exec);

/**
* LLM prompt configuration
*/
Expand Down Expand Up @@ -123,64 +120,19 @@ export class LlmInstallationManager {
// Construct command with file name and instruction
const prompt = `"Follow ${fileName} to install hagicode desktop and follow the instructions in it."`;

if (platform === 'win32') {
// Windows: Directly spawn claude process
try {
log.info('[LlmInstallationManager] Windows command:', `claude "${prompt}"`);
spawn('claude', [prompt], {
detached: true,
stdio: 'ignore',
cwd: promptDir,
shell: true,
}).unref();
terminalFound = true;
log.info('[LlmInstallationManager] Spawned Windows terminal successfully');
} catch (err) {
log.error('[LlmInstallationManager] Failed to spawn Windows terminal:', err);
}
} else if (platform === 'darwin') {
// macOS: Open new Terminal window and run claude with prompt
try {
const escapedPrompt = prompt.replace(/"/g, '\\"').replace(/\$/g, '\\$');
constructedCommand = `osascript -e 'tell application "Terminal" to do script "claude \\"${escapedPrompt}\\"; read -p \\"Press enter to exit...\\"; exit"'`;
log.info('[LlmInstallationManager] macOS command:', constructedCommand);
await execAsync(constructedCommand);
terminalFound = true;
log.info('[LlmInstallationManager] Opened macOS terminal successfully');
} catch (err) {
log.error('[LlmInstallationManager] Failed to open macOS terminal:', err);
}
} else {
// Linux: Open new terminal window and run claude with prompt
// Try common terminal emulators
const terminals = [
'gnome-terminal', // GNOME
'konsole', // KDE
'xfce4-terminal', // XFCE
'xterm', // Fallback
];

// Use the first available terminal
for (const term of terminals) {
try {
// Test if the terminal is available
await execAsync(`which ${term}`);
log.info(`[LlmInstallationManager] Using terminal: ${term}`);

// Escape the prompt for bash
const escapedPrompt = prompt.replace(/'/g, "'\\''");
constructedCommand = `${term} -- bash -c "claude '${escapedPrompt}'; read -p 'Press enter to exit...'; exit"`;

log.info('[LlmInstallationManager] Executing:', constructedCommand);
await execAsync(constructedCommand);
terminalFound = true;
log.info('[LlmInstallationManager] Opened Linux terminal successfully');
break;
} catch (err) {
log.warn(`[LlmInstallationManager] Failed to open ${term}:`, err);
continue;
}
}
// Spawn claude process across all platforms
try {
log.info('[LlmInstallationManager] Command:', `claude "${prompt}"`);
spawn('claude', [prompt], {
detached: true,
stdio: 'ignore',
cwd: promptDir,
shell: true,
}).unref();
terminalFound = true;
log.info('[LlmInstallationManager] Spawned claude successfully');
} catch (err) {
log.error('[LlmInstallationManager] Failed to spawn claude:', err);
}

// Save debug state if debug mode is enabled
Expand Down
Loading