build: drop the test suite from the serial and omp presets - #5
Merged
Conversation
The serial and omp presets are for building the simulation programs, but they also configured and ran the GoogleTest suite, which made GoogleTest an effective prerequisite for the ordinary build path. Both now set SLIMED_BUILD_TESTS=OFF, so tests/CMakeLists.txt is never added and find_package(GTest) never runs -- verified by the absence of any GTest entry in either build directory's CMakeCache.txt. Their workflow presets stop after the build step, and their test presets are removed. The coverage preset is unchanged: coverage without tests is pointless, so it still builds and runs them and still needs GoogleTest. SLIMED_BUILD_TESTS still defaults to ON, so a plain `cmake -S . -B build-test` includes the tests as before. The README's test instructions now use that directory rather than build/, which the serial preset populates without a test target. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The serial and omp presets are for building the simulation programs, but they also configured and ran the GoogleTest suite, which made GoogleTest an effective prerequisite for the ordinary build path.
Both now set SLIMED_BUILD_TESTS=OFF, so tests/CMakeLists.txt is never added and find_package(GTest) never runs -- verified by the absence of any GTest entry in either build directory's CMakeCache.txt. Their workflow presets stop after the build step, and their test presets are removed.
The coverage preset is unchanged: coverage without tests is pointless, so it still builds and runs them and still needs GoogleTest.
SLIMED_BUILD_TESTS still defaults to ON, so a plain
cmake -S . -B build-testincludes the tests as before. The README's test instructions now use that directory rather than build/, which the serial preset populates without a test target.