Skip to content

Advance Valence 3 Phase 2 mechanical proof - #176

Open
yingyue2030699 wants to merge 11 commits into
mainfrom
codex/valence3-phase2-scientific-packet
Open

Advance Valence 3 Phase 2 mechanical proof#176
yingyue2030699 wants to merge 11 commits into
mainfrom
codex/valence3-phase2-scientific-packet

Conversation

@yingyue2030699

Copy link
Copy Markdown
Member

Extends the proof-only Valence 3 OpenSubdiv lane with real-row transpose identities, canonical source-keyed preparation, production-shaped scatter and repeated 1/2/4-buffer reduction, and true net-force/net-torque invariants. Exact tetrahedron fixtures pass. The non-provider mixed 3/4/5 characterization exposes and preserves a 5.20e-3 volume-force translation residual as a production blocker. No production route, default caller, one-ring mutation, or CUDA changes. Verified with the OpenSubdiv 3.7 enabled and dependency-disabled proof runner.

@yingyue2030699

Copy link
Copy Markdown
Member Author

Verification summary: dedicated OpenSubdiv 3.7 proof PASS (dependency-disabled plus enabled, 1m43s). Independent subagent review PASS with no actionable findings. Repository build and coverage each ran 210 tests and passed 209; both fail only the existing unrelated EnergyForceEvaluatorTest.SharedHelperRecordsScaffoldEnergyAndForceSideEffects test. This PR changes only the Valence 3 proof experiment, its inventory assertions, and documentation; production and CUDA paths are untouched.

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 3.31754% with 408 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/energy_force/Valence3_opensubdiv_face_loop.cpp 0.78% 381 Missing ⚠️
src/mesh/OpenSubdiv_valence3_row_provider.cpp 0.00% 23 Missing ⚠️
.../energy_force/Compute_energy_and_force_on_mesh.cpp 73.33% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

yingyue2030699 and others added 2 commits August 5, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant