Harden legacy one-ring index safety - #212
Open
yingyue2030699 wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
WP1.1a safety only: make unreachable legacy one-ring index reads impossible and make failures explicit.
No fixture output changed. No geometry was corrected. This PR produces evidence for D5 but does not decide D5, and it does not implement WP1.1b. It changes no energy, force, volume, quadrature, OpenSubdiv, CUDA, output, or checkpoint behavior.
Verification
env -u OPENSUBDIV_ROOT make test && env -u OPENSUBDIV_ROOT ./bin/test_main: 254/254 passscripts/verify_pr_ready.sh: PASS, all 13 steps; 254/254 passd6a92152dff2ac60b1d56acf26da7fdd266f6b964f42d172711e679b41008ba2git diff --check: pass