Split legacy defect witness lifecycle - #213
Open
yingyue2030699 wants to merge 14 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work package: B0d
Records only; no source change.
This splits the legacy 11-control inventory entry by owner and lifecycle. The retained
Gauss_quadrature.cppmatrix defect remains a mandatory witness owned by D5. The WP1.1a classifier repair is a current-tree state record: it derives sentinel initialization and rejection-before-publication directly from the checked-outsrc/mesh/Mesh_setup_geometry.cppand permits either internally consistent boolean state.On current main/B0d the classifier repair is false. In both tested merge orders with PR 212 it becomes true, while the matrix defect remains true. No unmerged-branch commit or PR 212 SHA is pinned by the inventory.
The repair observer retains the readable structural/cardinality checks and additionally requires the normalized whole active
Mesh_setup_geometry.cppcontent contractad05d22b1d0fcadb1d1f4a80e7f4d49cbcc38dd66b9914a340229d88ef391e98. The contract is content-derived, not a commit identity: it preserves active code, each ordered active preprocessing directive as a separate C++ logical-line element, include operands, exact ordinary/character/raw literal tokens, and an alternating code/literal surface that binds each literal to its normalized source position; normalizes only ASCII C++ whitespace without collapsing distinct tokenizations or directive boundaries; ignores only comments and balanced simple literal-#if 0blocks without an active alternative; and fails closed on all other conditional, macro, Unicode-whitespace, or incomplete lexical state. CRLF and CR are phase-normalized to LF before backslash-newline splicing, then each phase-3 comment is replaced by one space so block-comment internals cannot invent line boundaries. Exact adversarial mutations cover the demonstrated P8 bypass families.This unblocks PR 212 V0 after B0d lands and PR 212 is rebased and freshly reviewed. It decides nothing: D5 and every other decision status remain untouched, and it does not claim the legacy stratum is correct, safe, resolved, or quarantined.
Exact head:
22f485e3e5102be7ae1928dc4ec91cfa6bffb612Base:
origin/main@6acac80f09bcfdc27dd3b3eca1f55be02379147aEvidence:
status: ok,errors: []on unrepaired main state#if 0fake repair: remains false.clear(),.push_back(), whole-field assignment, or indexed assignment on either publication field before rejection: remains falsedecltype/structured-binding/type-alias sentinel redeclarations: remain falsenamespacetoken: remains false; harmless directive spacing, trailing comments, and backslash splices preserve the contract??=if 0is treated as active source and remains false; valid%:if 0digraph syntax remains an inactive control#if 0syntax remain false; CRLF/CR new-line spellings preserve the reviewed state#ifexpression fails closed; comment-bearing literal-zero expressions and valid%:if 0controls remain accepted#if 0declaration/macro controls do not create false negativessrc/**andinclude/**absent from the B0d diffAll reviews of prior exact heads
113b0ce9f17b5e960c95116fbb7e23dbaa96cba9,75b87a3781c0b613c50e1ead826d4fa2100c9009,926f70f2c86b720f46ea4d3e9030d22c8fe9caa5,03769396033de46e0ce60b31a9fa86b485f072f2,3d4d11f7e9d6fa1cb21adf448541fd099950496d,627c460e5a67e826f0130a5348d7d6c5dc13e44b,0988ba201c8cc4b34e8e6dc73e95636a61f5a6a2,b644dc83d97901fd21dc8650c57ee46fc0dc856d,d803ef9b5c522bf824462b5ce0298db262cf559c,a267a415b99b6b80a6f549ef2db3606c234a5a38,569bcbe8536aff6384586be838e6c7115ae40dfb,b4943b1a25fd011cbe949d1cc23985b49b7ce87e, andbfe857df4f711991ba20725d3389cb1a4c7934caare void. The controlling FAIL reviews produced the fail-closed mutation families and C++17 phase-aligned directive/literal-placement/comment/whitespace-bound whole-source contract above.