Skip to content

Split legacy defect witness lifecycle - #213

Open
yingyue2030699 wants to merge 14 commits into
mainfrom
codex/inventory-defect-witness-split
Open

Split legacy defect witness lifecycle#213
yingyue2030699 wants to merge 14 commits into
mainfrom
codex/inventory-defect-witness-split

Conversation

@yingyue2030699

@yingyue2030699 yingyue2030699 commented Aug 27, 2026

Copy link
Copy Markdown
Member

Work package: B0d

Records only; no source change.

This splits the legacy 11-control inventory entry by owner and lifecycle. The retained Gauss_quadrature.cpp matrix defect remains a mandatory witness owned by D5. The WP1.1a classifier repair is a current-tree state record: it derives sentinel initialization and rejection-before-publication directly from the checked-out src/mesh/Mesh_setup_geometry.cpp and permits either internally consistent boolean state.

On current main/B0d the classifier repair is false. In both tested merge orders with PR 212 it becomes true, while the matrix defect remains true. No unmerged-branch commit or PR 212 SHA is pinned by the inventory.

The repair observer retains the readable structural/cardinality checks and additionally requires the normalized whole active Mesh_setup_geometry.cpp content contract ad05d22b1d0fcadb1d1f4a80e7f4d49cbcc38dd66b9914a340229d88ef391e98. The contract is content-derived, not a commit identity: it preserves active code, each ordered active preprocessing directive as a separate C++ logical-line element, include operands, exact ordinary/character/raw literal tokens, and an alternating code/literal surface that binds each literal to its normalized source position; normalizes only ASCII C++ whitespace without collapsing distinct tokenizations or directive boundaries; ignores only comments and balanced simple literal-#if 0 blocks without an active alternative; and fails closed on all other conditional, macro, Unicode-whitespace, or incomplete lexical state. CRLF and CR are phase-normalized to LF before backslash-newline splicing, then each phase-3 comment is replaced by one space so block-comment internals cannot invent line boundaries. Exact adversarial mutations cover the demonstrated P8 bypass families.

This unblocks PR 212 V0 after B0d lands and PR 212 is rebased and freshly reviewed. It decides nothing: D5 and every other decision status remain untouched, and it does not claim the legacy stratum is correct, safe, resolved, or quarantined.

Exact head: 22f485e3e5102be7ae1928dc4ec91cfa6bffb612
Base: origin/main@6acac80f09bcfdc27dd3b3eca1f55be02379147a

Evidence:

  • V0 inventory: status: ok, errors: [] on unrepaired main state
  • Focused mutation tests: 19 passed
  • Disabled #if 0 fake repair: remains false
  • Empty rejection branch plus detached sibling throw: remains false
  • Active .clear(), .push_back(), whole-field assignment, or indexed assignment on either publication field before rejection: remains false
  • Nested/uninitialized/comma redeclaration of each sentinel: remains false
  • Constructor/braced/decltype/structured-binding/type-alias sentinel redeclarations: remain false
  • Macro-hidden pre-rejection mutations of either publication field: remain false
  • Out-of-scope helper mutating both fields plus a preflight call: remains false
  • Count-preserving uninitialized sentinel shadow and staged-value corruption: remains false
  • Potentially active or unmatched conditional preprocessing and include drift: remain false
  • Active ordinary/reason/character/raw literal mutations: remain false
  • Joining the include directive to the following namespace token: remains false; harmless directive spacing, trailing comments, and backslash splices preserve the contract
  • Removed C++17 trigraph spelling ??=if 0 is treated as active source and remains false; valid %:if 0 digraph syntax remains an inactive control
  • VT/FF include-line joins and NBSP in code, source boundaries, or #if 0 syntax remain false; CRLF/CR new-line spellings preserve the reviewed state
  • Multiline block-comment joins across includes or pragmas remain false; safe leading/trailing and token-separating block comments preserve the reviewed state
  • Relocating ordinary, character, or raw literals across structural code remains false; exact prefix, suffix, adjacency, and normalized placement are bound
  • Appending ordinary, character, or raw literal tokens to an otherwise literal-zero inactive #if expression fails closed; comment-bearing literal-zero expressions and valid %:if 0 controls remain accepted
  • Placing ordinary, character, or raw literal tokens before a would-be directive marker cannot fabricate an inactive arm: raw phase-3 and masked surfaces must recognize the same anchored directive; comment prefixes remain valid
  • Commented and literal-#if 0 declaration/macro controls do not create false negatives
  • B0d-first plus PR 212 synthesis: conflict-free and inventory ok; classifier repair true
  • PR 212-first plus B0d synthesis: conflict-free and inventory ok; classifier repair true
  • src/** and include/** absent from the B0d diff
  • PR 211 owned-entry collision count: 0

All reviews of prior exact heads 113b0ce9f17b5e960c95116fbb7e23dbaa96cba9, 75b87a3781c0b613c50e1ead826d4fa2100c9009, 926f70f2c86b720f46ea4d3e9030d22c8fe9caa5, 03769396033de46e0ce60b31a9fa86b485f072f2, 3d4d11f7e9d6fa1cb21adf448541fd099950496d, 627c460e5a67e826f0130a5348d7d6c5dc13e44b, 0988ba201c8cc4b34e8e6dc73e95636a61f5a6a2, b644dc83d97901fd21dc8650c57ee46fc0dc856d, d803ef9b5c522bf824462b5ce0298db262cf559c, a267a415b99b6b80a6f549ef2db3606c234a5a38, 569bcbe8536aff6384586be838e6c7115ae40dfb, b4943b1a25fd011cbe949d1cc23985b49b7ce87e, and bfe857df4f711991ba20725d3389cb1a4c7934ca are void. The controlling FAIL reviews produced the fail-closed mutation families and C++17 phase-aligned directive/literal-placement/comment/whitespace-bound whole-source contract above.

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant