Skip to content

Replace two scratch paths in design docs, drop their exclusions, raise the Runner job's timeout - #166

Merged
kikashy merged 1 commit into
mainfrom
docs-scratch-paths-and-timeout
Oct 20, 2026
Merged

kikashy merged 1 commit into
mainfrom
docs-scratch-paths-and-timeout

Conversation

@kikashy

@kikashy kikashy commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Closes #164.

  • Replace the Go cache and wire capture scratch paths in the design documents with <scratch>.
  • Remove those documents' exclusions from the local-paths check while retaining its test-data exclusions.
  • Raise the Runner job timeout from 15 to 25 minutes.

Checks:

  • scripts/dev/check.sh --only local-paths,diff-check,agent-docs

Built by Codex CLI from a coordinator brief; a narrow review follows.

Co-Authored-By: Codex <noreply@openai.com>
Signed-off-by: kikashy <35789537+kikashy@users.noreply.github.com>
@kikashy

kikashy commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

Narrow review record (cross-vendor: built by OpenAI Codex CLI from a coordinator brief, reviewed by a clean-room Claude Sonnet agent)

The build: codex exec with gpt-5.6-sol at medium effort, from a brief naming the three changes; Codex made the edits, wrote the commit message and the pull-request body, ran the focused checks, and stopped at the commit because its sandbox keeps .git read-only; the coordinator committed with Codex's message and trailer and opened the pull request. Verdict: mergeable — head 2018ac44cd560f45355723b6a5dd351538dc6d35, no findings. Verbatim report follows, with the quoted paths reduced.


Review of judgment-pack-runner PR 166, head 2018ac4. Read-only; nothing posted. No findings at any severity.

  1. Exactly the three changes: yes. The diff is 4 files, 5 insertions and 7 deletions.
    • docs/design/executor-ownership.md: the Go cache path (a temporary-directory path) became <scratch> in three commands. The prose is otherwise unchanged.
    • docs/design/manual-admission-store-prepare-shape.md: the wire capture path became <scratch>. The sentence is otherwise byte-identical.
    • scripts/checks/local-paths.sh: only the two whole-file exclusions for those documents were removed. docs/design/manual-admission-store-prepare-wire.json, internal/runner/cloud_test.go, *.png and *.jpg are all still excluded.
    • .github/workflows/ci.yml: timeout-minutes went from 15 to 25 on the Runner (${{ matrix.os }}) job only. The release-contents job still has 10.
    • I found no other hunk.
  2. The check holds: yes.
    • scripts/dev/check.sh --only local-paths passes at the head.
    • Probe, in a scratch copy: I added a temporary-directory path to executor-ownership.md and a home-directory path to manual-admission-store-prepare-shape.md. The step failed with exit 1 and named both files and lines. So both documents are now covered. I deleted the probe copy afterwards.
  3. Hygiene: clean.

mergeable — head 2018ac4


Disposition: no finding; merged on green CI.

@kikashy
kikashy merged commit 30afd8b into main Oct 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace two scratch paths in design docs, drop their exclusions, and give the Runner job more headroom

1 participant