Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
check:
name: Runner (${{ matrix.os }})
runs-on: ${{ matrix.os }}
timeout-minutes: 15
timeout-minutes: 25
strategy:
fail-fast: false
matrix:
Expand Down
6 changes: 3 additions & 3 deletions docs/design/executor-ownership.md
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,8 @@ synchronize these observations; process IDs and elapsed time never determine
eligibility. A separate race test exercises concurrent `Close` and `Start`.

```sh
GOCACHE=/tmp/jps-policy-coverage-go-cache go test ./internal/runner -run '^TestExecutorLease' -count=1
GOCACHE=/tmp/jps-policy-coverage-go-cache go test -race ./internal/runner -run '^TestExecutorLease' -count=1
GOCACHE=<scratch> go test ./internal/runner -run '^TestExecutorLease' -count=1
GOCACHE=<scratch> go test -race ./internal/runner -run '^TestExecutorLease' -count=1
```

Running these tests on Linux demonstrates the tested Linux behavior. Compile
Expand Down Expand Up @@ -219,7 +219,7 @@ owner death cannot trigger a premature stdout failure at the protected boundary.
The integration requires `JPACK_TEST_BIN` and does not substitute a mock process.

```sh
GOCACHE=/tmp/jps-policy-coverage-go-cache JPACK_TEST_BIN=/absolute/path/to/jpack \
GOCACHE=<scratch> JPACK_TEST_BIN=/absolute/path/to/jpack \
go test -race ./cmd/jpack-runner ./internal/runner -run '^TestExecutorOwn' -count=1
```

Expand Down
2 changes: 1 addition & 1 deletion docs/design/manual-admission-store-prepare-shape.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Private nonexecuting manual-store preparation v1

Frozen jointly with Desk/coordinator for implementation. `jpack-runner prepare-manual-store` accepts no arguments, exactly one bounded UTF-8 JSON+LF request on stdin (≤16KiB including LF), then EOF. Closed schemas and synthetic vectors: `/tmp/jps-policy-manual-admission-store-prepare-wire.json`. Exact casing, no duplicates/unknown/null/type coercion; canonical uint64 decimal strings must not overflow. Paths are existing clean absolute private real directories with disjoint state/external custody. No secret boot, authority socket, listener, provider, Runtime, recovery or worker.
Frozen jointly with Desk/coordinator for implementation. `jpack-runner prepare-manual-store` accepts no arguments, exactly one bounded UTF-8 JSON+LF request on stdin (≤16KiB including LF), then EOF. Closed schemas and synthetic vectors: `<scratch>`. Exact casing, no duplicates/unknown/null/type coercion; canonical uint64 decimal strings must not overflow. Paths are existing clean absolute private real directories with disjoint state/external custody. No secret boot, authority socket, listener, provider, Runtime, recovery or worker.

Request: version1, stable random bare64hex prepareId, dir, Runner workspace, existing owner, leaseFd3, existing executorOwnership v1, executionDemand v1. Demand is exactly version1, installationId, machineWorkspace, runnerWorkspace, executorId, profile local-admin-manual-pack/1. Repeated identities must agree with current state, retained external custody and Desk pending intent. Device/inode IDs remain strings.

Expand Down
2 changes: 0 additions & 2 deletions scripts/checks/local-paths.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
# written in a design note before this check existed. A new file is checked.
set -e
if git grep -nE '(^|[^A-Za-z0-9_])/(home|tmp)/[A-Za-z0-9_.-]+' -- . ':!*.png' ':!*.jpg' \
':!docs/design/executor-ownership.md' \
':!docs/design/manual-admission-store-prepare-shape.md' \
':!docs/design/manual-admission-store-prepare-wire.json' \
':!internal/runner/cloud_test.go'; then
echo 'a machine-local path is in tracked text'; exit 1
Expand Down
Loading