Skip to content

Fix deferred spotlight camera coordinates - #52

Merged
Lemiort merged 1 commit into
masterfrom
bugfix/26-spotlight-world-space
Oct 24, 2026
Merged

Lemiort merged 1 commit into
masterfrom
bugfix/26-spotlight-world-space

Conversation

@Lemiort

@Lemiort Lemiort commented Oct 24, 2026

Copy link
Copy Markdown
Owner

Closes #26.

Summary

  • keep the deferred spotlight camera position in world space instead of transforming it by model/view/projection matrices
  • add an OpenGL regression test that verifies a non-identity projection does not alter the camera position received by the fragment shader

Verification

  • cmake --build build/build/Release --target NEE opengl_render_tests
  • ctest --test-dir build/build/Release -R DeferredSpotlightKeepsCameraPositionInWorldSpace --output-on-failure
  • ctest --test-dir build/build/Release --output-on-failure --no-tests=error (34/34 passed)

@Lemiort
Lemiort merged commit 806b96f into master Oct 24, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P1] Fix deferred spotlight coordinate-space calculations

1 participant