Repository navigation
Keep Git transfers and readers compatible with complete stored history - #249
Merged
nishu-builder merged 0 commit intoSep 18, 2026
Conversation
This was referenced Sep 17, 2026
Merged
nishu-builder
added this pull request to stack #255
September 17, 2026 23:43
nishu-builder
force-pushed
the
codex/publish-git-compat-20260917-911f8bae
branch
from
September 17, 2026 23:48
85d641b to
7d37ace
Compare
nishu-builder
force-pushed
the
codex/publish-git-compat-20260917-911f8bae
branch
from
September 17, 2026 23:54
7d37ace to
e910bb5
Compare
nishu-builder
commented
Sep 17, 2026
nishu-builder
left a comment
Contributor
Author
There was a problem hiding this comment.
Layer 2/8. The HTTP_GIT_PROTOCOL pass-through, the alternates-after-staging reorder in validate_commit_with_git, and the consumer-fetch and 40-pack assertions in the fixture all look right and are the kind of thing that only shows up under load.
Two inline comments, both about cost rather than correctness: dropping --depth 1 makes every :@@= resolution (including the cloud install's --llm-step locator) download the target repo's full history, and Slots::Given(32767) is now an absolute ceiling on pack count in a store that nothing ever repacks.
Generated by Claude Code
nishu-builder
force-pushed
the
codex/publish-git-compat-20260917-911f8bae
branch
from
September 18, 2026 00:03
e910bb5 to
2aacd94
Compare
nishu-builder
force-pushed
the
codex/publish-git-compat-20260917-911f8bae
branch
from
September 18, 2026 00:48
2aacd94 to
4ba34e5
Compare
nishu-builder
removed this pull request from stack #255
September 18, 2026 07:50
nishu-builder
added this pull request to stack #257
September 18, 2026 07:51
nishu-builder
force-pushed
the
codex/publish-git-compat-20260917-911f8bae
branch
from
September 18, 2026 10:52
4ba34e5 to
f748548
Compare
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has been split into three smaller PRs below the publication design:
:@@=loads from (falsely) indicating to the server they have missing commit ancestry #260 — Keep snapshot fetches from making client repositories shallow.Each replacement explains the failure it fixes and carries its relevant regression tests. The publication design is #248, above these fixes. The combined code is unchanged.
GitHub automatically marked this PR merged into the design branch during reordering because that branch contained its rewritten head. Nothing was merged into main. The fixes remain open for review in the three PRs above.