Skip to content

Expose GitHub CLI through the agent github tool - #254

Closed
nishu-builder wants to merge 1 commit into
codex/publish-github-worker-20260917-911f8baefrom
codex/publish-github-tool-20260917-911f8bae
Closed

nishu-builder wants to merge 1 commit into
codex/publish-github-worker-20260917-911f8baefrom
codex/publish-github-tool-20260917-911f8bae

Conversation

@nishu-builder

@nishu-builder nishu-builder commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Expose github(repository, args, stdin?) through std/github, using lazy worker evaluation and the existing callback path. Share repository validation with the worker and label uncertain results prominently so they are not treated as safe-to-retry command failures.

Extend the branch design with GitHub invocation recovery, PR creation/updates and stack workflows using existing PR URLs. Retain the full stored request across recovery, including its worker and credential identity.

The fixture covers registration, secret grants, lazy evaluation, callback, version/help and replay. Live PR writes and stack linking remain follow-up validation.

Validation on EC2: Nix build passed. The salted suite passed 46/47 checks in 395s; its Clippy findings were fixed, and Clippy passed on all affected crates with --all-targets -- -D warnings. Formatting passed after those lint-only fixes. HTTPS import/push, shallow-locator/offline-cache, and focused unit checks also passed. The functional suite was not repeated for the lint-only changes.

@nishu-builder nishu-builder left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layer 7/8. The bind-as-data / evaluate-when-called trick via std/llm-step/github/DEPS is a neat way to keep the secret-marked worker out of the agent's own reader identity, and the comment explains why. The invocation id derived from (conversation, request, round, call) gives exactly the "new call, new id; resumed call, same id" the design wants, and resume goes through the stored task so a rebuilt image does not re-key a half-done call. The stub-driven tests/github extension checks the registry, the callback and the source_tree parameter on publish_source, which closes the "registry silently drops a tool" hole from CLAUDE.md.

Two minor inline comments (duplicated repository validation, and making uncertain visually distinct from a plain non-zero exit in the result block). Nothing blocking.


Generated by Claude Code

Comment thread std/llm-step/src/github.rs Outdated
Comment thread std/llm-step/src/github.rs
@nishu-builder
nishu-builder force-pushed the codex/publish-github-tool-20260917-911f8bae branch 2 times, most recently from 1b567b0 to 2c45a9a Compare September 18, 2026 00:48
@nishu-builder
nishu-builder force-pushed the codex/publish-github-tool-20260917-911f8bae branch from 2c45a9a to 7016ca3 Compare September 18, 2026 01:12
@nishu-builder
nishu-builder force-pushed the codex/publish-github-tool-20260917-911f8bae branch from 7016ca3 to 01d04f9 Compare September 18, 2026 07:50
@nishu-builder
nishu-builder removed this pull request from stack #255 September 18, 2026 07:50
@nishu-builder
nishu-builder added this pull request to stack #257 September 18, 2026 07:51
@nishu-builder
nishu-builder force-pushed the codex/publish-github-tool-20260917-911f8bae branch from 01d04f9 to 63a1bc1 Compare September 18, 2026 10:52
@nishu-builder
nishu-builder removed this pull request from stack #257 September 18, 2026 10:52
@nishu-builder
nishu-builder added this pull request to stack #257 September 18, 2026 10:52
@nishu-builder
nishu-builder removed this pull request from stack #257 September 18, 2026 10:53
@nishu-builder
nishu-builder added this pull request to stack #261 September 18, 2026 10:53
@nishu-builder
nishu-builder force-pushed the codex/publish-github-tool-20260917-911f8bae branch from 63a1bc1 to fce1539 Compare September 18, 2026 19:52
@nishu-builder
nishu-builder force-pushed the codex/publish-github-tool-20260917-911f8bae branch from fce1539 to 78ba4e9 Compare September 18, 2026 19:53
@nishu-builder
nishu-builder force-pushed the codex/publish-github-tool-20260917-911f8bae branch from 78ba4e9 to 70cc559 Compare September 19, 2026 01:44

Copy link
Copy Markdown
Contributor Author

Closing with the rest of stack #261. #300 replaces this: the agent's github tool runs inline in llm-step against the REST API, with no std/github worker or gh. The implementation follows in a PR stacked on #300.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant