Repository navigation
Add shared authored force fields and accepted recording custody - #145
Merged
Merged
Conversation
added 5 commits
October 20, 2026 22:09
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
MrScripty
marked this pull request as ready for review
October 21, 2026 00:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authoring previously had no shared external-field document/evaluator for the native MAC and particle-material paths. This draft adds versioned scene objects, immutable run snapshots, directional/radial/vortex fields with bounded support/falloff, opt-in solver adapters, and force-aware accepted pressure/control and recording custody.
Initial supported scope is closed-box MAC and raw particle-material APIs. Emitters, existing gravity, pair/material forces and turbulence remain separate. Force density divides by constant MAC density or evaluated local particle density. Legacy recording branches/hash algorithms remain unchanged; opted-in runs bind a versioned complete force document to the run header and every publication.
Validation:
Five exact adapter tests: authored_mac_matches_legacy_bounded_directional_force; authored_mac_cancellation_retains_accepted_state_and_retry; authored_particle_density_conversion_adds_to_existing_acceleration; authored_particle_cancel_retains_state_and_retry; empty_snapshot_preserves_both_legacy_paths.
Two exact recording tests: carrier_force_archive_round_trip_and_failed_attempt_invalidation; particle_force_archive_round_trip_and_rejected_control_custody.
The seven pure codec cases cover bit-preserving variants/IDs, truncation/versions/bounds, maximum-size scenes, run/step mismatch/absence/unbound metadata, invalid descriptors/custody, malformed run digests, and golden legacy run/step hashes.
Post-custody SHA-256 seals:
Exact commands, raw logs, helper bounds, failure-preservation caveats and prior/current seals are committed under docs/plans/force-authoring/validation.md and evidence/{pre-custody-adapters,post-custody-7970a5d}. The supervisor's resource/execution functions were reused byte-for-byte; only paths/seals/names/counts/output flag were configured. No cgroups, mounts or security settings changed.
Still pending: desktop controls/handles, Request/launch dispatch, frozen run-intent schemas and archive UI/rerun integration. No src/bin files changed. Session/provider/free-surface/column/box-flux combinations, emitter integration, successful legacy stamp clearing after authored steps, exhaustive historical archives and desktop parity are outside the executed evidence. These bounded checks are not scientific L1/MMS or calibrated-physics validation.
Base main: fd7c0f0.
Tested source head: 7970a5d.
Current published head: 43ec505 (evidence/docs only after tested head).
Keep draft for coordinated UI integration and repository-lead review. No merge or branch deletion. CI status must be assessed independently for the latest head.