Repository navigation
Conversation
Nano and Super stay on the pinned release:1.3.0rc22 image. Edge is served from a source build that includes Cosmos3EdgeForConditionalGeneration. Signed-off-by: Yiming Zhao <yimingz@nvidia.com>
pengcuo
left a comment
There was a problem hiding this comment.
Adding to @ishovkun's comments (PID reuse and wait in a fresh shell, missing Edge shutdown, unconditional docker pull, request parity), all of which I agree with. Two more:
- The Edge path depends on an unmerged TensorRT-LLM PR. NVIDIA/TensorRT-LLM#20307 is still open (head
ConstBob:cosmos3-edge-reasoner, mergeable state blocked as of today), and no release up to v1.4.0rc1 containsCosmos3EdgeForConditionalGeneration. The README tells readers to install "from a checkout that includes PR 20307" without naming a branch or commit, so the instructions cannot be followed from upstreammainor from any image. Either hold the Edge section until it ships in a release image (then pin that image like Nano/Super), or name the exact fork branch and commit and label the section as a preview. - The Edge launch cell runs
python -m pip install opencv-python-headlesswith whateverpythonis first on the%%bashPATH, which is not necessarily the environment that ownstrtllm-serve(the Nano/Super cells install it inside the container, where that is unambiguous). Install into the interpreter that owns the entry point, e.g."$(dirname "$(command -v trtllm-serve)")/python" -m pip install ..., or move it to the prerequisites.
The rest of the readiness cell reads correctly to me (Docker-absent branch, Edge PID liveness check).
Stop only a confirmed Edge server, shut that process down with the container, and skip the Nano/Super image pull when Docker is absent. Point the Edge source build at TensorRT-LLM main after 39a44fab. Signed-off-by: Yiming Zhao <yimingz@nvidia.com>
|
closing this PR. will merge 299 instead |
|
@ConstBob , very sorry, I closed this one by accident. I meant to close the one in the cosmos repo. Could you please reopen this tomorrow? We're making some changes to the cookbook, see PR 324, your changes need to be on top of that one. |
|
Hi @yaoxu-crypto , I tried to reopen this, but the Reopen pull request button does not show up on the page. |
|
Hi @yaoxu-crypto , since this pull request still cannot be reopened, I opened a new one on current main, on top of the changes you mentioned: #347 |
Summary
Add Cosmos3-Edge to the TensorRT-LLM Reasoner cookbook.
Cosmos3-Nano and Cosmos3-Super stay on the pinned
nvcr.io/nvidia/tensorrt-llm/release:1.3.0rc22image. That image does not includeCosmos3EdgeForConditionalGeneration, so Cosmos3-Edge is documented as a single-GPU server started from a TensorRT-LLM source build that includes NVIDIA/TensorRT-LLM#20307.Changes
cookbooks/cosmos3/README.mdtrtllm-servecommand on port 8001.cookbooks/cosmos3/reasoner/README.mdcookbooks/cosmos3/reasoner/run_with_tensorrt_llm.ipynbrelease:1.3.0rc22.trtllm-serve nvidia/Cosmos3-Edgefrom the current environment and exits with a clear message whentrtllm-serveis unavailable.Testing
bash -non every bash cell./healthserver:nvidia/Cosmos3-Edgecheckpoint, using a TensorRT-LLM environment that includes the Edge architecture.trtllm-serve nvidia/Cosmos3-Edge --host 0.0.0.0 --port 8001 --max_num_tokens 32768started successfully./healthbecame ready./v1/modelsreturnedCosmos3-Edge.assets/robot_153.jpgreturned a non-empty caption.The run used
max_tokens=128for the image request; the cookbook example keepsmax_tokens=4096. Nano and Super launch commands are unchanged and were not rerun.