Repository navigation
Conversation
Replay the reviewed Edge Reasoner cookbook onto main after the generate-media skill migration. Nano and Super stay on release:1.3.0rc22. Edge is served from TensorRT-LLM main at or after 39a44fab. Signed-off-by: Yiming Zhao <yimingz@nvidia.com>
lfengad
reviewed
Oct 31, 2026
| [`39a44fab`](https://github.com/NVIDIA/TensorRT-LLM/commit/39a44fab74f4cfc0d4d498be385e746fdd182872) | ||
| (the merge of [PR 20307](https://github.com/NVIDIA/TensorRT-LLM/pull/20307)), | ||
| following the | ||
| [TensorRT-LLM Generator source-build instructions](#tensorrt-llm-generator), |
Collaborator
There was a problem hiding this comment.
Could we please make the linked source-build steps select a revision that actually includes Edge Reasoner support? This paragraph correctly requires 39a44fab or newer, but the linked TensorRT-LLM Generator instructions still run git checkout cc63e66daf52644f1441e117bb7ba67d20566016 (README line 202). I checked the upstream commit ancestry: cc63e66 is an ancestor of 39a44fab and predates the Edge Reasoner merge, so following that build block literally does not meet this prerequisite. An explicit Edge-specific checkout override at 39a44fab or newer, or corrected linked instructions, would avoid that contradiction while keeping the Nano/Super release-image path unchanged. Thank you!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nvcr.io/nvidia/tensorrt-llm/release:1.3.0rc22.mainbuild at or after39a44fab(the merge of [None][feat] Add Cosmos3-Edge Reasoner support TensorRT-LLM#20307). Release images throughv1.4.0rc1do not includeCosmos3EdgeForConditionalGeneration.Testing