[goldyfruit]

Follow-up to #704, per review on related PRs: avoid defensive getattr for attributes that must exist.

SkillResources._vocabularies_memo was only created by the first _locale_vocabularies() call, so the read used getattr(self, "_vocabularies_memo", None). It is now set to None in __init__ and read directly. No behaviour change.

Tests: test_resource_files.py, test_resource_files_extended.py and test_resource_lookup_cache.py pass (72). The rest of the unit suite matches dev (13 local failures on both, from the host's inotify limit and one skill_launcher test).

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 7b947cdf-39c0-483d-983f-c890d1dd6b1e

📥 Commits

Reviewing files that changed from the base of the PR and between ebd5bd0 and 4b27980.

📒 Files selected for processing (1)

• ovos_workshop/resource_files.py

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}