Skip to content

refactor: initialise the vocabulary memo in __init__, no getattr #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JarbasAl merged 1 commit into from
Oct 13, 2026
Merged

refactor: initialise the vocabulary memo in __init__, no getattr #708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ovos_workshop/resource_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,6 +800,9 @@ def __init__(self, skill_directory: str,
self.types = self._define_resource_types()
self._dialog_renderer = dialog_renderer
self.static = dict()
# (directories, file signature, vocabularies, last check) of the last
# _locale_vocabularies() call, see there
self._vocabularies_memo: Optional[tuple] = None

@property
def dialog_renderer(self) -> MustacheDialogRenderer:
Expand Down Expand Up @@ -939,7 +942,7 @@ def _locale_vocabularies(self) -> Dict[str, List[str]]:
vocab_type = self.types.vocabulary
cacheable = not vocab_type.user_directory
if cacheable:
memo = getattr(self, "_vocabularies_memo", None)
memo = self._vocabularies_memo
if memo is not None and memo[0] == (vocab_type.base_directory,
vocab_type.workshop_directory) \
and _still_fresh(memo[1], memo[3]):
Expand Down
Loading