Repository navigation
fix(support): Stop model Equals throwing when the other list is null - #9
Merged
Merged
Conversation
The generated Equals compared list properties with SequenceEqual without checking the other instance's list, so comparing a model that has a list against one that does not threw ArgumentNullException instead of returning false. Raised by CodeRabbit on abuzuhri#960. Tests: added Equals_ReturnsFalseWhenOnlyOneSideHasAList. Full suite passes (18/18). Breaking: no
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings 80b2dc0 from feature/support-api (upstream abuzuhri#960) into integration/AMZDW. Tests: full suite passes.