Skip to content

fix(support): Stop model Equals throwing when the other list is null #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ProNotion merged 1 commit into from
Oct 21, 2026
Merged

fix(support): Stop model Equals throwing when the other list is null #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Source/FikaAmazonAPI/AmazonSpApiSDK/Models/Support/Case.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,11 +275,13 @@ public bool Equals(Case input)
(
this.CcEmails == input.CcEmails ||
this.CcEmails != null &&
input.CcEmails != null &&
this.CcEmails.SequenceEqual(input.CcEmails)
) &&
(
this.Appointments == input.Appointments ||
this.Appointments != null &&
input.Appointments != null &&
this.Appointments.SequenceEqual(input.Appointments)
) &&
(
Expand Down
3 changes: 3 additions & 0 deletions Source/FikaAmazonAPI/AmazonSpApiSDK/Models/Support/CaseFilters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ public bool Equals(CaseFilters input)
(
this.CaseStatuses == input.CaseStatuses ||
this.CaseStatuses != null &&
input.CaseStatuses != null &&
this.CaseStatuses.SequenceEqual(input.CaseStatuses)
) &&
(
Expand All @@ -204,11 +205,13 @@ public bool Equals(CaseFilters input)
(
this.PrimaryEmails == input.PrimaryEmails ||
this.PrimaryEmails != null &&
input.PrimaryEmails != null &&
this.PrimaryEmails.SequenceEqual(input.PrimaryEmails)
) &&
(
this.CcEmails == input.CcEmails ||
this.CcEmails != null &&
input.CcEmails != null &&
this.CcEmails.SequenceEqual(input.CcEmails)
) &&
(
Expand Down
1 change: 1 addition & 0 deletions Source/FikaAmazonAPI/AmazonSpApiSDK/Models/Support/ChatContent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ public bool Equals(ChatContent input)
(
this.Events == input.Events ||
this.Events != null &&
input.Events != null &&
this.Events.SequenceEqual(input.Events)
) &&
(
Expand Down
1 change: 1 addition & 0 deletions Source/FikaAmazonAPI/AmazonSpApiSDK/Models/Support/ChatEvent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ public bool Equals(ChatEvent input)
(
this.Attachments == input.Attachments ||
this.Attachments != null &&
input.Attachments != null &&
this.Attachments.SequenceEqual(input.Attachments)
);
}
Expand Down
1 change: 1 addition & 0 deletions Source/FikaAmazonAPI/AmazonSpApiSDK/Models/Support/EmailContent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ public bool Equals(EmailContent input)
(
this.Attachments == input.Attachments ||
this.Attachments != null &&
input.Attachments != null &&
this.Attachments.SequenceEqual(input.Attachments)
);
}
Expand Down
1 change: 1 addition & 0 deletions Source/FikaAmazonAPI/AmazonSpApiSDK/Models/Support/ErrorList.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ public bool Equals(ErrorList input)
(
this.Errors == input.Errors ||
this.Errors != null &&
input.Errors != null &&
this.Errors.SequenceEqual(input.Errors)
);
}
Expand Down
1 change: 1 addition & 0 deletions Source/FikaAmazonAPI/AmazonSpApiSDK/Models/Support/ListCasesResult.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ public bool Equals(ListCasesResult input)
(
this.Cases == input.Cases ||
this.Cases != null &&
input.Cases != null &&
this.Cases.SequenceEqual(input.Cases)
);
}
Expand Down
1 change: 1 addition & 0 deletions Source/FikaAmazonAPI/AmazonSpApiSDK/Models/Support/ListContactsResult.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ public bool Equals(ListContactsResult input)
(
this.Contacts == input.Contacts ||
this.Contacts != null &&
input.Contacts != null &&
this.Contacts.SequenceEqual(input.Contacts)
);
}
Expand Down
12 changes: 12 additions & 0 deletions Source/Tests/SupportTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,18 @@ public void ListContactsResult_DeserialisesChatEvents()
Assert.That(contact.ChatContent.Events[0].Participant.Role, Is.EqualTo(Participant.RoleEnum.AMAZON));
}

[Test]
public void Equals_ReturnsFalseWhenOnlyOneSideHasAList()
{
var timestamp = new DateTime(2024, 1, 12, 11, 0, 0, DateTimeKind.Utc);
var withAttachments = new ChatEvent(timestamp: timestamp, type: ChatEvent.TypeEnum.ATTACHMENT,
attachments: new List<Attachment> { new Attachment(name: "file.txt") });
var withoutAttachments = new ChatEvent(timestamp: timestamp, type: ChatEvent.TypeEnum.ATTACHMENT);

Assert.That(withAttachments.Equals(withoutAttachments), Is.False);
Assert.That(withoutAttachments.Equals(withAttachments), Is.False);
}

[Test]
public void ParameterListCases_SerialisesToAmazonRequestBody()
{
Expand Down