ci: update ffi-check for PyPy symbol mangling change - #6389
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
|
This probably needs an update. PyPy3.11 will keep the old names, PyPy3.12 will be using unmangled names for all the CPython limited API functions. You can see the latest CI run with PyPy3.12 at https://github.com/pypy/binary-testing/actions/runs/34744801359/job/103690612698 |
|
Wow. Sorry for the many many required changes. |
|
No worries; I think part of this is that PyO3 wasn't quite correctly mangling all the PyPy 3.11 symbols anyway, the more extensive checking applied here is catching existing flaws as well as preparing infrastructure to make sure we synchronise with PyPy 3.12 (and any future mangling changes). |
|
Thanks! |
* ci: update ffi-check for PyPy symbol mangling change * fix formatting * fix ffi check failures on older versions * fix pypy 3.11 link aliases * fmt * try fix windows build * try to fix windows * try switch to allowlist for bindgen * try to make link failures on windows easier to diagnose * fix link name for pypy without raw-dylib * fix missing PyPy link name attributes * only decorate x86 symbols on `raw-dylib` builds * Update link name for PyVectorcall_Call in abstract_.rs * fmt
As per pypy/binary-testing#55 (comment) this updates ffi-check to confirm that symbols are being resolved properly for PyPy ahead of the change in PyPy 3.12 to support abi3 by removing the special
PyPyprefix from many functions.I make this practical by forcing pyo3-ffi-check to resolve actual addresses of all functions and check they match the pypy headers.