fix raw-dylib opt-out on windows x86 - #6410
Merged
Merged
Conversation
ngoldbaum
reviewed
Sep 15, 2026
ngoldbaum
left a comment
ngoldbaum
left a comment
Contributor
There was a problem hiding this comment.
I had an AI model look over this an it spotted some issues.
| // for `raw-dylib` in general, rather than as a patch here. | ||
| // | ||
| // Assert expected raw pypy dll name as a sanity check for now | ||
| assert_eq!( |
Contributor
There was a problem hiding this comment.
I think this would make a config file with implementation=PyPy, version=3.11, and lib_name=python311 fail when PYO3_USE_RAW_DYLIB=0. I think you need to preserve explicitly-configured DLL names.
Member
Author
There was a problem hiding this comment.
Would you be amenable to this being dealt with in a follow-up? I think probably the raw-dylib stuff all needs to be refactored to move to pyo3-build-config properly rather than dealt with in pyo3-ffi.
(I don't think any such hypothetical pypy build with python311.dll is likely to be a real-world case, though the AI model is right that this patch here is a hack.)
davidhewitt
enabled auto-merge
September 15, 2026 21:04
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 15, 2026
davidhewitt
added a commit
that referenced
this pull request
Sep 17, 2026
* fix raw-dylib opt-out on windows x86 * newsfragment * correct PyPy build failures * `PyVectorcall_Call` is 3.12+ * workaround incorrect lib name for PyPy with raw-dylib opt out * fix `PyVectorcall_Call` cfg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #6389 - this PR applies the changes to
pyo3-ffi-check(with a FIXME for PyPy which that PR will resolve), CI andnoxfile.py, while leaving thepyo3-ffifixes for PyPy for the followup.The discovery in #6389 was that 32-bit windows' opt-out for
raw-dylibmerged in #6185 is slightly broken because the workaround for_link names is still applied. This PR fixes that.I think this'll also fix the 32-bit windows failure seen in PyO3/setuptools-rust#615