Skip to content

build: use github.com/Quality-Max/qmax-code module path - #217

Closed
Desperado wants to merge 1 commit into
mainfrom
Desperado/go-module-path-quality-max
Closed

Desperado wants to merge 1 commit into
mainfrom
Desperado/go-module-path-quality-max

Conversation

@Desperado

Copy link
Copy Markdown
Contributor

Why

pkg.go.dev returns 404 for qmax-code. go.mod declares github.com/qualitymax/qmax-code, which doesn't exist on GitHub, so proxy.golang.org serves a go.mod that doesn't match the repository path github.com/Quality-Max/qmax-code. Awesome Go requires a working pkg.go.dev page.

Changes

  • Changes the module path and all imports to github.com/Quality-Max/qmax-code. The 94 changed files are mechanical import rewrites plus gofmt import reordering.
  • Adds doc.go so pkg.go.dev shows a command overview.
  • README: adds a Go Reference badge and a go install github.com/Quality-Max/qmax-code@latest option.
  • CI: writes a coverage profile and uploads it to Codecov using OIDC, with no stored token. Uploads are non-blocking.

After merge

Tag a patch release so the proxy indexes a version with the matching go.mod, then request it on pkg.go.dev.

Release binaries and curl | bash installs are unaffected.

Verification

go build, go vet, golangci-lint v1.64.8, and go test ./... pass locally.

The module was declared as github.com/qualitymax/qmax-code, which does
not resolve on GitHub, so proxy.golang.org served a mismatched go.mod and
pkg.go.dev returned 404. Match the repository path, add command docs and
a Go Reference badge, and upload coverage from CI.
@qualitymaxapp

qualitymaxapp Bot commented Oct 16, 2026

Copy link
Copy Markdown

QualityMax Review

Reviewing 7931f4da27f7 now.

Max's current mission: Max is reviewing the diff from his tiny laptop.

 /\_/\     _________
( o.o )   /_______/|
 > ^ <    | qmax  | |
 /| |\   |_______|/
(_| |_)

The completed review will replace this message.

@qualitymaxapp

qualitymaxapp Bot commented Oct 16, 2026

Copy link
Copy Markdown

⚠️ QualityMax Diff Analysis — WARN

Diff analysis incomplete after 1 of 2 bounded review batches: batch 2 returned malformed review evidence. The PR performs a module rename from 'github.com/qualitymax/qmax-code' to 'github.com/Quality-Max/qmax-code', which constitutes a breaking change for all downstream consumers. The CI/CD updates correctly implement OIDC-based coverage reporting, but the module rename should be accompanied by a major version bump or clear communication to users.

🟡 Finding 1: breaking

File: go.mod:1 | Severity: warning

What: The module path has been renamed. This will break all existing 'go.mod' files and import statements in downstream projects that depend on this repository.

Fix: Ensure this change is accompanied by a major version release (e.g., v2.0.0) and provide a migration guide for users.

Fix with your LLM agent
<your-llm-agent> "Fix the breaking issue in go.mod at line 1: The module path has been renamed. This will break all existing 'go.mod' files and import statements in downstream projects that depend on this repository."
Fix all findings with your LLM agent
<your-llm-agent> "Fix all QualityMax review findings in this PR:\n- breaking in go.mod:1: The module path has been renamed. This will break all existing 'go.mod' files and import statements in downstream projects that depend on this repository."

Change diagram — Flow

flowchart LR
    A[Push/PR] --> B[Checkout Code]
    B --> C[Run Tests]
    C --> D{Tests Pass?}
    D -- Yes --> E[Generate coverage.out]
    E --> F[Upload to Codecov via OIDC]
    D -- No --> G[Fail Build]
Loading

Analyzed commit 7931f4da with gemini-3.1-flash-lite (64 files, 25188 tokens) | Customize review preferences

@codecov-commenter

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants