Repository navigation
Add opt-in Haiku 5.5 and expand regression coverage - #218
Conversation
The module was declared as github.com/qualitymax/qmax-code, which does not resolve on GitHub, so proxy.golang.org served a mismatched go.mod and pkg.go.dev returned 404. Match the repository path, add command docs and a Go Reference badge, and upload coverage from CI.
QualityMax ReviewVerdict: COMMENT · Confidence: model judgment; findings have not been reproduced Re-review: Open the QualityMax check and select Re-review after it completes. Files eligible: 148 · Files reviewed: 148 · Files with findings: 2 · Findings: 2 · Inline cards: 0 Priority findings
Review gates
Important files
Advisory MODEL-ONLY candidates (2)These model judgments do not block this PR and are not posted inline. Check reachable callers and existing protections, and reproduce a concrete failure before treating a candidate as a defect. A second model's confirmation or a model-reviewed patch does not reproduce a failure.
Change diagram — Flowflowchart TD
subgraph Command_Execution
A[User Input] --> B{handleCCCommand}
B --> C[readClaudeCodeAuthFile]
C --> D{Valid JSON?}
D -- No --> E[Return Error]
D -- Yes --> F[uploadClaudeCodeAuth]
F --> G[Claude Code Connection]
end
Review lifecycleUse the inline cards to inspect evidence and suggested remediation. Re-run the QualityMax review after pushing a fix; unchanged cards are identified by their stable finding marker. Dismiss with a reason through the existing QualityMax/GitHub review feedback flow. 0 prior card(s) are stale/resolved on this head. Proof legend: GROUNDED deterministic scanner evidence · MODEL-ONLY advisory model judgment · MODEL-REVIEWED patch model judgment, not reproduction. QualityMax project results are available in the configured project. Receipt · commit |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
| Gate | Result |
|---|---|
| 🔍 AI diff review | ℹ️ 3 advisory MODEL-ONLY candidate(s) · gemini-3.1-flash-lite · completed · 148 eligible / 148 reviewed · gemini-3.1-flash-lite |
| 🔍 SAST | completed · 150 eligible / 150 reviewed · qwen3.7-plus |
| 🔍 Canonical PR review delivery | completed · 0 eligible / 0 reviewed · exact-head review #5557297713 and overview #6224175696 confirmed |
| 🧪 Repo Tests | ✅ 1460/1460 passed (go) |
| 🤖 AI Tests |
Powered by QualityMax — AI-Powered Test Automation
|
|
Adds Haiku 5.5 as an explicit model choice and expands regression coverage across the CLI. Selecting
/model claude-haiku-5-5or its Anthropic API / Claude Code picker entry opts in;haiku, automatic chat routing, and vision defaults stay on Haiku 4.5 until verification is complete.Changes
mainand currently includes that shared groundwork; merge build: use github.com/Quality-Max/qmax-code module path #217 first.Validation
go test -coverprofile=.context/coverage-pr.out -covermode=atomic ./...— pass; aggregate coverage 85.5%.go vet ./...— pass.golangci-lint run— pass.-ldflags='-s -w -X main.Version=dev'— pass.Known limits
The broader race run fails in terminal/stdout test handling and readline shutdown.
TestAgyRunStreamsAndRecordsUsageandTestRunOllamaModeCyclealso reproduce these failures on the branch's pre-Haiku commit; the broad race run is not green.Live Haiku 5.5 provider verification is still pending. No automatic model upgrade, tag, or public release is included. Tests use fake credentials and local services; credential storage, subprocess credential policy, and outbound egress guards are unchanged.