Repository navigation
[mlir] Skip uniquer locks when a context starts without threading (#2… - #5113
Merged
Merged
Conversation
aobolensk
added a commit
to aobolensk/llvm-project
that referenced
this pull request
Oct 26, 2026
amd-staging disables MLIR threading for every context, so its uniquers skip locks and this test races Fixes the check-mlir failure in ROCm#5113
aobolensk
added a commit
to aobolensk/llvm-project
that referenced
this pull request
Oct 26, 2026
MLIR_ENABLE_THREADS is never defined, which left every context without threading and its uniquers lock-free. Fixes the MLIRIRTests failure in ROCm#5113
ronlieb
pushed a commit
that referenced
this pull request
Oct 26, 2026
MLIR_ENABLE_THREADS is never defined, which left every context without threading and its uniquers lock-free Fixes the MLIRIRTests failure in #5113
ronlieb
enabled auto-merge (squash)
October 26, 2026 16:08
aobolensk
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…35294)
attempt to land, has mysterious MLIR LIT failure