Skip to content

[mlir] Skip uniquer locks when a context starts without threading (#2… #5113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ronlieb merged 4 commits into from
Oct 26, 2026
Merged

[mlir] Skip uniquer locks when a context starts without threading (#2… #5113

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ffd1c0d
[mlir] Skip uniquer locks when a context starts without threading (#2…
aobolensk Oct 24, 2026
02015ca
Merge branch 'amd-staging' into amd/dev/rlieberm/reland/MLIRPath
ronlieb Oct 25, 2026
55e9ec0
Merge branch 'amd-staging' into amd/dev/rlieberm/reland/MLIRPath
ronlieb Oct 26, 2026
c1f2414
Merge branch 'amd-staging' into amd/dev/rlieberm/reland/MLIRPath
ronlieb Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions mlir/lib/IR/MLIRContext.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,8 +286,16 @@ class MLIRContextImpl {
if (threadingIsEnabled) {
ownedThreadPool = std::make_unique<llvm::DefaultThreadPool>();
threadPool = ownedThreadPool.get();
} else {
disableUniquerMultithreading(true);
}
}
/// Update the threading mode for each of the uniquers.
void disableUniquerMultithreading(bool disable) {
affineUniquer.disableMultithreading(disable);
attributeUniquer.disableMultithreading(disable);
typeUniquer.disableMultithreading(disable);
}
~MLIRContextImpl() {
for (auto typeMapping : registeredTypes)
typeMapping.second->~AbstractType();
Expand Down Expand Up @@ -624,10 +632,7 @@ void MLIRContext::disableMultithreading(bool disable) {

impl->threadingIsEnabled = !disable;

// Update the threading mode for each of the uniquers.
impl->affineUniquer.disableMultithreading(disable);
impl->attributeUniquer.disableMultithreading(disable);
impl->typeUniquer.disableMultithreading(disable);
impl->disableUniquerMultithreading(disable);

// Destroy thread pool (stop all threads) if it is no longer needed, or create
// a new one if multithreading was re-enabled.
Expand Down
Loading