Repository navigation
Bind SNAuth external login to browser state and S256 proof - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External-login callbacks could be redeemed without proof of the browser transaction that initiated sign-in. Bind authorization/MFA codes to state, S256 challenge and callback; validate proof before atomic consumption and preserve the binding through remembered login, MFA, registration and password recovery. Restrict callbacks to the allowed application origin and correct temporary-token expiry from days to configured minutes.
Existing clients that omit all binding fields remain compatible; partial binding and proof-bearing redemption of legacy codes are rejected. Deploy this server before the companion SenseNet/sn-client codex/auth-lifecycle-fixes change. The new client intentionally reports an error against an old unbound callback. Parallel-session and SingleSessionPerUser behavior remain covered.
Validation: full solution 86/86 tests passed (76 integration, 10 unit); release publish succeeded. Independent source review found no concrete blocker. See docs/external-login.md for the protocol/rollout and the companion AdminUI authentication acceptance matrix for the planned user test round. No deployment performed.