Repository navigation
[MS-1605] Add face capture attempt events #1853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
85 changes: 85 additions & 0 deletions
85
...c/main/java/com/simprints/face/capture/screens/livefeedback/AutoCaptureAttemptRecorder.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| package com.simprints.face.capture.screens.livefeedback | ||
|
|
||
| import androidx.lifecycle.SavedStateHandle | ||
| import com.simprints.core.tools.extensions.area | ||
| import com.simprints.core.tools.time.TimeHelper | ||
| import com.simprints.core.tools.time.Timestamp | ||
| import com.simprints.face.capture.models.FaceDetection | ||
| import com.simprints.face.capture.usecases.SimpleCaptureEventReporter | ||
| import com.simprints.infra.config.store.models.ModalitySdkType | ||
| import kotlinx.coroutines.CoroutineScope | ||
| import kotlinx.coroutines.launch | ||
|
|
||
| /** | ||
| * Owns the auto-capture attempt in progress: starts it, feeds it frames, persists it for process | ||
| * death and reports it as a [com.simprints.infra.events.event.domain.models.FaceCaptureAttemptEvent]. | ||
| */ | ||
| internal class AutoCaptureAttemptRecorder( | ||
| private val savedStateHandle: SavedStateHandle, | ||
| private val eventReporter: SimpleCaptureEventReporter, | ||
| private val timeHelper: TimeHelper, | ||
| private val scope: CoroutineScope, | ||
| ) { | ||
| private var bioSdk: String? = null | ||
|
|
||
| @Volatile | ||
| var activeAttempt: AutoCaptureAttemptStats? = null | ||
| private set | ||
|
|
||
| init { | ||
| reportAttemptPersistedBeforeProcessDeath() | ||
| } | ||
|
|
||
| fun setBioSdk(sdk: ModalitySdkType) { | ||
| bioSdk = sdk.name | ||
| } | ||
|
|
||
| fun start(attemptNb: Int) { | ||
| // Report any unfinished previous attempt as abandoned | ||
| finish() | ||
| activeAttempt = bioSdk | ||
| ?.let { AutoCaptureAttemptStats(attemptNb = attemptNb, bioSdk = it, startTime = timeHelper.now()) } | ||
| .also { savedStateHandle[KEY_ATTEMPT_STATS] = it?.snapshot() } | ||
| } | ||
|
|
||
| fun record( | ||
| attempt: AutoCaptureAttemptStats, | ||
| faceDetection: FaceDetection, | ||
| frameTime: Timestamp, | ||
| frameWidth: Int, | ||
| frameHeight: Int, | ||
| ) { | ||
| attempt.recordFrame( | ||
| detection = faceDetection, | ||
| areaOccupied = faceDetection.face?.relativeBoundingBox?.area(), | ||
| frameTime = frameTime, | ||
| frameWidth = frameWidth, | ||
| frameHeight = frameHeight, | ||
| ) | ||
| attempt.snapshotIfDue()?.let { snapshot -> | ||
| scope.launch { | ||
| // The attempt may have been finished while this write was queued | ||
| if (activeAttempt === attempt) savedStateHandle[KEY_ATTEMPT_STATS] = snapshot | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // Removes the saved-state key synchronously: onCleared runs after viewModelScope is cancelled | ||
| fun finish() { | ||
| val attempt = activeAttempt ?: return | ||
| activeAttempt = null | ||
| eventReporter.addCaptureAttemptEvent(attempt.toEvent(timeHelper.now())) | ||
| savedStateHandle.remove<String>(KEY_ATTEMPT_STATS) | ||
| } | ||
|
|
||
| private fun reportAttemptPersistedBeforeProcessDeath() { | ||
| val snapshot = savedStateHandle.get<String>(KEY_ATTEMPT_STATS) ?: return | ||
| savedStateHandle.remove<String>(KEY_ATTEMPT_STATS) | ||
| val restored = AutoCaptureAttemptStats.restore(snapshot) ?: return | ||
| eventReporter.addRecoveredCaptureAttemptEvent(restored.toEvent(endTime = restored.lastFrameTime)) | ||
| } | ||
|
|
||
| companion object { | ||
| internal const val KEY_ATTEMPT_STATS = "face_auto_capture_attempt_stats" | ||
| } | ||
| } | ||
287 changes: 287 additions & 0 deletions
287
.../src/main/java/com/simprints/face/capture/screens/livefeedback/AutoCaptureAttemptStats.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,287 @@ | ||
| package com.simprints.face.capture.screens.livefeedback | ||
|
|
||
| import com.simprints.core.tools.time.Timestamp | ||
| import com.simprints.core.tools.utils.randomUUID | ||
| import com.simprints.face.capture.models.FaceDetection | ||
| import com.simprints.infra.events.event.domain.models.FaceCaptureAttemptEvent | ||
| import com.simprints.infra.events.event.domain.models.FaceCaptureAttemptEvent.FaceCaptureAttemptPayload.RejectionMetric | ||
| import com.simprints.infra.events.event.domain.models.FaceCaptureAttemptEvent.FaceCaptureAttemptPayload.RejectionStats | ||
| import com.simprints.infra.events.event.domain.models.FaceCaptureAttemptEvent.FaceCaptureAttemptPayload.RunStatus | ||
| import com.simprints.infra.events.event.domain.models.FaceCaptureAttemptEvent.FaceCaptureAttemptPayload.StatusRun | ||
| import com.simprints.infra.events.event.domain.models.FaceCaptureAttemptEvent.FaceCaptureAttemptPayload.ValueStats | ||
| import kotlinx.serialization.Serializable | ||
| import kotlinx.serialization.json.Json | ||
| import kotlin.random.Random | ||
|
|
||
| /** | ||
| * Accumulates auto-capture attempt diagnostics into a [FaceCaptureAttemptEvent]. | ||
| * Not thread-safe: confine it to the analyser executor. | ||
| */ | ||
| internal class AutoCaptureAttemptStats private constructor( | ||
| private val state: State, | ||
| private val random: Random, | ||
| ) { | ||
| constructor( | ||
| attemptNb: Int, | ||
| bioSdk: String, | ||
| startTime: Timestamp, | ||
| random: Random = Random.Default, | ||
| ) : this(State(attemptNb = attemptNb, bioSdk = bioSdk, startTime = startTime), random) | ||
|
|
||
| val attemptNb: Int get() = state.attemptNb | ||
| val startTime: Timestamp get() = state.startTime | ||
|
|
||
| val lastFrameTime: Timestamp get() = state.lastFrameTime ?: state.startTime | ||
|
|
||
| private var hasFramesSinceSnapshot = false | ||
|
|
||
| private var lastSnapshotMs: Long? = null | ||
|
|
||
| @Synchronized | ||
| fun recordFrame( | ||
| detection: FaceDetection, | ||
| areaOccupied: Float?, | ||
| frameTime: Timestamp, | ||
| frameWidth: Int, | ||
| frameHeight: Int, | ||
| ) { | ||
| val offsetMs = (frameTime.ms - state.startTime.ms).coerceAtLeast(0L) | ||
| val runStatus = detection.status.toRunStatus() | ||
|
|
||
| state.totalFramesAnalysed++ | ||
| state.lastFrameTime = frameTime | ||
| if (state.targetFrameWidth == null) { | ||
| state.targetFrameWidth = frameWidth | ||
| state.targetFrameHeight = frameHeight | ||
| } | ||
|
|
||
| detection.face?.quality?.let { state.qualityAllFrames.add(it, random) } | ||
|
|
||
| if (runStatus == RunStatus.VALID) { | ||
| state.validFrameCount++ | ||
| if (state.timeToFirstValidMs == null) state.timeToFirstValidMs = offsetMs | ||
| } else { | ||
| val reason = state.reasons.getOrPut(runStatus) { ReasonState(firstSeenMs = offsetMs) } | ||
| reason.count++ | ||
| decidingValue(detection, areaOccupied)?.let { reason.values.add(it, random) } | ||
| } | ||
|
|
||
| advanceRuns(runStatus, offsetMs) | ||
| hasFramesSinceSnapshot = true | ||
| } | ||
|
|
||
| @Synchronized | ||
| fun toEvent(endTime: Timestamp): FaceCaptureAttemptEvent { | ||
| val endOffsetMs = (endTime.ms - state.startTime.ms).coerceAtLeast(0L) | ||
| closeOpenRun(endOffsetMs) | ||
|
|
||
| return FaceCaptureAttemptEvent( | ||
| startTime = state.startTime, | ||
| endTime = endTime, | ||
| attemptNb = state.attemptNb, | ||
| bioSdk = state.bioSdk, | ||
| targetFrameWidth = state.targetFrameWidth, | ||
| targetFrameHeight = state.targetFrameHeight, | ||
| totalFramesAnalysed = state.totalFramesAnalysed, | ||
| validFrameCount = state.validFrameCount, | ||
| timeToFirstValidMs = state.timeToFirstValidMs, | ||
| rejectionStats = RejectionStats( | ||
| invalid = state.reasons[RunStatus.INVALID]?.toMetric(), | ||
| badQuality = state.reasons[RunStatus.BAD_QUALITY]?.toMetric(), | ||
| offYaw = state.reasons[RunStatus.OFF_YAW]?.toMetric(), | ||
| offRoll = state.reasons[RunStatus.OFF_ROLL]?.toMetric(), | ||
| tooClose = state.reasons[RunStatus.TOO_CLOSE]?.toMetric(), | ||
| tooFar = state.reasons[RunStatus.TOO_FAR]?.toMetric(), | ||
| ), | ||
| qualityAllFrames = state.qualityAllFrames.toValueStats(), | ||
| statusRuns = state.closedRuns.map { StatusRun(it.status, it.frameCount, it.durationMs) }, | ||
| statusRunsTruncated = state.statusRunsTruncated, | ||
| id = state.eventId, | ||
| ) | ||
| } | ||
|
|
||
| @Synchronized | ||
| fun snapshot(): String { | ||
| hasFramesSinceSnapshot = false | ||
| lastSnapshotMs = state.lastFrameTime?.ms | ||
| return json.encodeToString(State.serializer(), state) | ||
| } | ||
|
|
||
| /** Snapshot on the first frame, then at most once per [SNAPSHOT_INTERVAL_MS] of frame time. */ | ||
| @Synchronized | ||
| fun snapshotIfDue(): String? { | ||
| if (!hasFramesSinceSnapshot) return null | ||
| val nowMs = state.lastFrameTime?.ms ?: return null | ||
| val last = lastSnapshotMs | ||
| if (last != null && nowMs - last < SNAPSHOT_INTERVAL_MS) return null | ||
| return snapshot() | ||
| } | ||
|
|
||
| private fun advanceRuns( | ||
| status: RunStatus, | ||
| offsetMs: Long, | ||
| ) { | ||
| val open = state.openRun | ||
| if (open != null && open.status == status) { | ||
| open.frameCount++ | ||
| return | ||
| } | ||
| if (open != null) closeRun(open, endOffsetMs = offsetMs) | ||
| state.openRun = OpenRun(status = status, startMs = offsetMs, frameCount = 1) | ||
| } | ||
|
|
||
| private fun closeOpenRun(endOffsetMs: Long) { | ||
| state.openRun?.let { closeRun(it, endOffsetMs) } | ||
| state.openRun = null | ||
| } | ||
|
|
||
| private fun closeRun( | ||
| run: OpenRun, | ||
| endOffsetMs: Long, | ||
| ) { | ||
| val durationMs = (endOffsetMs - run.startMs).coerceAtLeast(0L) | ||
|
|
||
| state.reasons[run.status]?.let { reason -> | ||
| if (durationMs > reason.longestRunMs) reason.longestRunMs = durationMs | ||
| } | ||
|
|
||
| if (state.closedRuns.size < FaceCaptureAttemptEvent.MAX_STATUS_RUNS) { | ||
| state.closedRuns.add(ClosedRun(run.status, run.frameCount, durationMs)) | ||
| } else { | ||
| state.statusRunsTruncated = true | ||
| } | ||
| } | ||
|
|
||
| private fun decidingValue( | ||
| detection: FaceDetection, | ||
| areaOccupied: Float?, | ||
| ): Float? = when (detection.status) { | ||
| FaceDetection.Status.TOOFAR, | ||
| FaceDetection.Status.TOOCLOSE, | ||
| -> areaOccupied | ||
|
|
||
| FaceDetection.Status.OFFYAW -> detection.face?.yaw | ||
| FaceDetection.Status.OFFROLL -> detection.face?.roll | ||
| FaceDetection.Status.BAD_QUALITY -> detection.face?.quality | ||
| FaceDetection.Status.NOFACE, | ||
| FaceDetection.Status.VALID, | ||
| FaceDetection.Status.VALID_CAPTURING, | ||
| -> null | ||
| } | ||
|
|
||
| private fun ReasonState.toMetric(): RejectionMetric { | ||
| val stats = values.toValueStats() | ||
| return RejectionMetric( | ||
| count = count, | ||
| firstSeenMs = firstSeenMs, | ||
| longestRunMs = longestRunMs, | ||
| minValue = stats?.minValue, | ||
| maxValue = stats?.maxValue, | ||
| medianValue = stats?.medianValue, | ||
| ) | ||
| } | ||
|
|
||
| @Serializable | ||
| private class State( | ||
| // Persisted so an attempt recovered after process death keeps its event id | ||
| val eventId: String = randomUUID(), | ||
| val attemptNb: Int, | ||
| val bioSdk: String, | ||
| val startTime: Timestamp, | ||
| var lastFrameTime: Timestamp? = null, | ||
| var targetFrameWidth: Int? = null, | ||
| var targetFrameHeight: Int? = null, | ||
| var totalFramesAnalysed: Int = 0, | ||
| var validFrameCount: Int = 0, | ||
| var timeToFirstValidMs: Long? = null, | ||
| val reasons: MutableMap<RunStatus, ReasonState> = mutableMapOf(), | ||
| val qualityAllFrames: BoundedSamples = BoundedSamples(), | ||
| val closedRuns: MutableList<ClosedRun> = mutableListOf(), | ||
| var openRun: OpenRun? = null, | ||
| var statusRunsTruncated: Boolean = false, | ||
| ) | ||
|
|
||
| @Serializable | ||
| private class ReasonState( | ||
| val firstSeenMs: Long, | ||
| var count: Int = 0, | ||
| var longestRunMs: Long = 0L, | ||
| val values: BoundedSamples = BoundedSamples(), | ||
| ) | ||
|
|
||
| /** Reservoir sample (Algorithm R): exact min/max, estimated median beyond [MAX_VALUE_SAMPLES]. */ | ||
| @Serializable | ||
| private class BoundedSamples( | ||
| var seen: Int = 0, | ||
| var minValue: Float? = null, | ||
| var maxValue: Float? = null, | ||
| val samples: MutableList<Float> = mutableListOf(), | ||
| ) { | ||
| fun add( | ||
| value: Float, | ||
| random: Random, | ||
| ) { | ||
| seen++ | ||
| val min = minValue | ||
| val max = maxValue | ||
| if (min == null || value < min) minValue = value | ||
| if (max == null || value > max) maxValue = value | ||
| if (samples.size < MAX_VALUE_SAMPLES) { | ||
|
luhmirin-s marked this conversation as resolved.
|
||
| samples.add(value) | ||
| } else { | ||
| val slot = random.nextInt(seen) | ||
| if (slot < MAX_VALUE_SAMPLES) samples[slot] = value | ||
| } | ||
| } | ||
|
|
||
| fun toValueStats(): ValueStats? { | ||
| val min = minValue ?: return null | ||
| val max = maxValue ?: return null | ||
| val sorted = samples.sorted() | ||
| val mid = sorted.size / 2 | ||
| val median = if (sorted.size % 2 == 0) (sorted[mid - 1] + sorted[mid]) / 2f else sorted[mid] | ||
| return ValueStats(minValue = min, maxValue = max, medianValue = median) | ||
| } | ||
| } | ||
|
|
||
| @Serializable | ||
| private class OpenRun( | ||
| val status: RunStatus, | ||
| val startMs: Long, | ||
| var frameCount: Int, | ||
| ) | ||
|
|
||
| @Serializable | ||
| private class ClosedRun( | ||
| val status: RunStatus, | ||
| val frameCount: Int, | ||
| val durationMs: Long, | ||
| ) | ||
|
|
||
| companion object { | ||
| internal const val MAX_VALUE_SAMPLES = 128 | ||
| internal const val SNAPSHOT_INTERVAL_MS = 1_000L | ||
|
|
||
| private val json = Json { encodeDefaults = true } | ||
|
|
||
| fun restore( | ||
| snapshot: String, | ||
| random: Random = Random.Default, | ||
| ): AutoCaptureAttemptStats? = runCatching { | ||
| AutoCaptureAttemptStats(json.decodeFromString(State.serializer(), snapshot), random) | ||
| }.getOrNull() | ||
|
|
||
| fun FaceDetection.Status.toRunStatus(): RunStatus = when (this) { | ||
| FaceDetection.Status.VALID, | ||
| FaceDetection.Status.VALID_CAPTURING, | ||
| -> RunStatus.VALID | ||
|
|
||
| FaceDetection.Status.NOFACE -> RunStatus.INVALID | ||
| FaceDetection.Status.BAD_QUALITY -> RunStatus.BAD_QUALITY | ||
| FaceDetection.Status.OFFYAW -> RunStatus.OFF_YAW | ||
| FaceDetection.Status.OFFROLL -> RunStatus.OFF_ROLL | ||
| FaceDetection.Status.TOOCLOSE -> RunStatus.TOO_CLOSE | ||
| FaceDetection.Status.TOOFAR -> RunStatus.TOO_FAR | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.