Repository navigation
Correct stale Effect and lint comments - #182
Merged
Merged
Conversation
The HttpApi skill still named Effect 4.0.3 after the pin moved to 4.0.5. The dynamic-import override no longer needs to cite the retired s0-lint allowlist. Co-authored-by: Jonathan Beckman <jonathantbeckman@gmail.com>
jonbeckman
marked this pull request as ready for review
November 8, 2026 09:28
Contributor
🟢 e2e solzero-core: no tests selected, 30 left out by filtersChange 2 files changed since 30 tests left out by filters
e2e 0.21.3 · 5ms · local-cloudflare · run artifacts |
Contributor
TegamiThis repository uses Tegami to manage releases. When your changes affect published packages, add a changelog file under Create a changelog → · Changelog format No changelogs yetThis PR has no pending changelog files. If your changes require a release, add a changelog before merging. Run Managed by Tegami. |
Co-authored-by: Jonathan Beckman <jonathantbeckman@gmail.com>
Co-authored-by: Jonathan Beckman <jonathantbeckman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates two comments that still describe an older toolchain.
effectis 4.0.5. The import path stayseffect/http-api. Effect 4.0.5 still does not exporteffect/httpapioreffect/unstable/httpapi.oxlint.config.tscited the retireds0-lintallowlist. The current reason remains: the workflow runner imports@cloudflare/dynamic-workflowson demand.release:none: comments only. No runtime or operator change.Validation
nub run typechecknub run lintnub run formatnub run testwas not run. No executable behavior changed.Checklist
.tegami/release entry, or explained why this pull request usesrelease:none.nub run config:check,nub run typecheck,nub run lint,nub run format, andnub run test. (config:checkandtestwere not run; see Validation.)THIRD_PARTY_NOTICES.mdfor new third-party code or separately licensed assets. (No new third-party code.)