Skip to content

Correct stale Effect and lint comments #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonbeckman merged 3 commits into from
Nov 9, 2026
Merged

Correct stale Effect and lint comments #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57fb7f8
Correct stale Effect and lint comments.
cursoragent Nov 8, 2026
9e65565
Retry validation after the actionlint download returned 504.
cursoragent Nov 8, 2026
8e7f625
Retry validation now that the actionlint installer responds.
cursoragent Nov 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .agents/skills/effect-httpapi-workers-patterns/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Use this skill when editing or reviewing an Effect HttpApi stack, generated Effe
- Keep API contracts separate from server implementation.
- Contract modules define `HttpApi`, `HttpApiGroup`, endpoints, schemas, tagged errors, and security declarations.
- Server route modules only implement `HttpApiBuilder.group(...)` live layers.
- Import `HttpApi`, `HttpApiBuilder`, `HttpApiClient`, and `HttpApiMiddleware` from `effect/http-api`. This repository pins Effect 4.0.3, which does not export `effect/unstable/httpapi` or `effect/httpapi`.
- Import `HttpApi`, `HttpApiBuilder`, `HttpApiClient`, and `HttpApiMiddleware` from `effect/http-api`. This repository pins Effect 4.0.5, which does not export `effect/unstable/httpapi` or `effect/httpapi`.
- Prefer named `Schema.Class` response/request types and `Schema.TaggedError` errors with `httpApiStatus`.
- Avoid broad `JsonRecord`, `AnyJson`, and generic `{ error: string }` contracts for real endpoints.
- If a generated client requires `unknown` or extra services, fix the schema contract instead of casting at the call site.
Expand Down
2 changes: 1 addition & 1 deletion oxlint.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ export default defineConfig({
},
},
{
// Carried over from the s0-lint allowlist: the runner imports @cloudflare/dynamic-workflows on demand.
// The runner imports @cloudflare/dynamic-workflows on demand.
files: ["packages/api/src/server/background/workflows/runner.ts"],
rules: { "solzero/prevent-dynamic-imports": "off" },
},
Expand Down
Loading