Repository navigation
Let each PR name the CI lanes it needs - #260
Merged
Merged
Conversation
A PR into main ran every lane, and since cloud merged into main every PR targets main, so a one-line Dart fix waited on the Windows build. Now a PR without a ci: line runs analyze, test and web plus the lanes its files reach. A ci: line in the description names lanes instead, or skips CI. Lanes guarding production and the library still run when their files change. An unknown lane name runs everything. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 47 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A one-line Dart fix (#258) was going to wait ~20 minutes on CI, Windows desktop build included. With this PR the agent that opens a PR says what CI it needs, and a PR like that can skip CI entirely.
Why every PR ran everything. The lane picker from #219 ran every lane for any PR into
main. When #219 landed, daily work targetedicarus-cloudand a PR intomainwas the release merge. Since #234 every PR targetsmain, so every PR paid for the full run. Direct-to-main PRs on Oct 5–7 took 14–20 minutes. #257 took 4.5 only because it was stacked on another branch until just before merge.What changes
ci:line:ci: test web,ci: skip, orci: all. The lanes are analyze, test, web, replay, convex, presence, contract, bridge and desktop.ci: tests, runs every lane and leaves a warning, so a typo can't silently skip CI.mainrun every lane but desktop, manual runs and PRs that touch.github/run everything, and a PR whose file list can't be read runs everything.native-replayis now a lane (replay) instead of running on every PR. Its Rust tests only covernative/replay/.AGENTS.mdgains one rule telling agents to write the line.Checked on a real run. Draft PR #259, stacked on this branch so it ran this workflow, then closed:
ci: skipci: analyze(edited, then rerun)Locally I ran the picker script with a stubbed
ghthrough 16 cases. They included a convex change withci: skip, which still ran convex and contract, and a.g.dartchange withci: test, which still ran desktop, plus push, dispatch, unreadable files and aci:that appears mid-sentence, which is ignored.Not covered. The guarded lanes running under a
ci:line was only tested locally. A live run would have deployed a Convex preview just to prove it. This PR runs every lane because it touches.github/.Skipped matrix jobs show as
test (shard ${{ matrix.shard }})in the checks list. GitHub doesn't expand a matrix it skips, and it's cosmetic.🤖 Generated with Claude Code