Skip to content

fix: preserve explicit TOP and OFFSET/FETCH limits - #30

Merged
debba merged 1 commit into
mainfrom
fix/26-preserve-explicit-row-limits
Sep 29, 2026
Merged

debba merged 1 commit into
mainfrom
fix/26-preserve-explicit-row-limits

Conversation

@debba

@debba debba commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Do not add host OFFSET/FETCH pagination to SELECT statements with explicit outer TOP or OFFSET/FETCH limits.
  • Keep automatic pagination for ordinary SELECTs and limits inside CTEs/subqueries.
  • Ignore quoted identifiers, variables, strings and nested comments when classifying SQL.
  • Add unit and live SQL Server coverage for single queries and batches.

Validation

  • 214 unit tests and 3 host-model conformance tests passed.
  • 2 live pagination tests passed against local SQL Server, using an isolated test database.
  • cargo clippy --all-targets -- -D warnings
  • cargo fmt --all -- --check

Issue scope

Refs #26. This addresses the plugin pagination half only; it intentionally does not close the issue.
The host Generate SQL modal still emits LIMIT. That will be addressed separately through an optional, backward-compatible SQL-template RPC extension in Tabularis and this plugin.

@debba debba added the prerelease:beta Publish the next release on the beta prerelease channel label Sep 29, 2026
@github-actions

Copy link
Copy Markdown

Version suggestion

Based on this PR's title (fix) and the prerelease:beta label:

Current 1.0.0-beta.2
Suggested next tag v1.0.0-beta.3

This is informational only — no tag or release is created automatically yet.

@debba
debba merged commit ce78440 into main Sep 29, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

prerelease:beta Publish the next release on the beta prerelease channel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant