Repository navigation
Conversation
Fold post-Policies numerics into typed bags while keeping flat kwargs as shortcuts. Freeze the public evolve() surface with EVOLVE_PARAM_ALLOWLIST, document the stable subset, and point new knobs at Policies or a bag.
|
Verdict: PASS SummaryCloses #804 cleanly: folds the post-Policies numeric/flag surface into typed Correctness
Design fitRight homes for the knobs: Policies for replaceable pieces, bags for spend/runtime/observability. Docs + CONTRIBUTING tell authors where new knobs go. Public exports and Nits (non-blocking)
Riskrisk_gate → T3 (paths: |
|
PASS Tip |
|
Verdict: PASS Note on tip changePrior PASS was on 56b27ac (bag implementation). Tip is now merge commit 556fe4b bringing main/#812 (MCP Path A) into the branch. Diff vs previous tip is only #812 files — no conflict with Budget/Runtime/Observability bags, allowlist, or evolve wiring. Re-verified bags + allowlist tests on the new tip. Summary (unchanged intent)Closes #804: typed settings bags, flat kwargs as shortcuts, EVOLVE_PARAM_ALLOWLIST freeze, docs/CONTRIBUTING/algorithm-authoring updated. Design and correctness notes from the prior tip review still hold. Riskrisk_gate → T3 (evolution.py, async_evolve.py, CONTRIBUTING.md). No auto-merge; waiting on Danyang click after required CI green on 556fe4b. |
Summary
Finishes the Policies consolidation promised when the bundle landed (#804).
BudgetSettings/RuntimeSettings/ObservabilitySettingswith flat kwargs as shortcuts (merged_with-style resolve).evolveandasync_evolve; regeneratedocs/api.md.EVOLVE_PARAM_ALLOWLIST+ test; document the stable subset indocs/evolution.md,CONTRIBUTING.md, and algorithm-authoring.Closes #804.
Test plan
pytest -q tests/test_evolve_settings.py tests/test_async_early_stop.py tests/test_budget.py tests/test_api_docs.pypython -m tools.gen_api_docs --check