Skip to content

test: wait for native Canvas readiness before Escape - #446

Merged
BunsDev merged 3 commits into
mainfrom
canvas-native-ready
Oct 30, 2026
Merged

BunsDev merged 3 commits into
mainfrom
canvas-native-ready

Conversation

@BunsDev

@BunsDev BunsDev commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

The Canvas full-view test could send Escape after React hid the main pane but before the native guest applied full-view bounds. Wait for the visible native Canvas view to match the expanded preview, including zoom and rounding, before sending the existing single Escape. Production behavior and the security, restoration and destruction assertions remain unchanged.

PR #443 failed this assertion in both its initial head run and protected queue run 40992737267. Controlled delayed-IPC diagnostics reproduce the readiness gap; hosted traces do not establish that event ordering conclusively. Both failures and traces are preserved in the linked repository evidence document. No sleep, input retry or timeout increase is added.

Validation: five candidate repetitions passed; build passed; unit checks passed with 2,244 passes and 26 skips. Full local E2E completed with exit 0: 475 desktop passes and seven skips (21.0 minutes), followed by seven site passes (8.3 seconds). The transcript median was 175.7 ms against the approved 500 ms limit. The tested head is 8638fd30a8b2d5e4eafc7fc543126f57bd9f3861, and the worktree remained clean. Source review found no blocking findings. Hosted macOS job 123878076309 in run 40998793846 passed 478 desktop tests with four skips and seven site tests, with a 382.7 ms transcript median. Protected delivery is pending. Human keyboard and VoiceOver acceptance remain separate; issues #280 and #281 retain their separate acceptance gates.

Evidence: docs/reviews/2026-10-30-canvas-native-readiness.md.

Hosted first failures and retry. Windows job 123877826277 passed 15 native CLI cases and failed the natural-exit PTY case while waiting for the grandchild heartbeat. One unchanged diagnostic retry with debug logging passed all 16 cases and the full Windows packaging job (123881380189); the cause of the first failure remains unknown. Both logs and digest-verified TAP artifacts are preserved. CodeQL Actions job 123877816315 failed after SARIF upload began, without a concrete error in its log or annotations; its retry request was rejected with HTTP 403. That failure remains recorded for the original head. The iPhone and required macOS jobs passed. Signed documentation-only commit d1e56c4bc717829606c448f63549b73a62434fcb now records these results; build and unit checks passed again (2,244 passes, 26 skips, zero failures). Application and test code are unchanged from the fully tested head. The branch now includes main through a34edc75e34c9eaba2b18eccecfeff417b2cd887 in signed merge commit b0d239507bdfb1d5f1e88ad88db793998464be87, resolving the status-document conflict while preserving the published release and landed Markdown repair records. Build and unit checks passed on the integrated tree (2,244 passes, 26 skips, zero failures), and all seven site E2E tests passed in 8.5 seconds. The Canvas implementation is unchanged from the fully tested head. All hosted checks passed for integrated head b0d239507bdfb1d5f1e88ad88db793998464be87. macOS job 123899056011 passed 478 desktop cases with four skips (30.3 minutes) and seven site cases (19.0 seconds), with a 323.5 ms transcript median. Windows, Linux, iPhone and CodeQL checks passed. This exact head was submitted to the protected merge queue without bypass; queue validation and merge remain pending. Earlier failures remain recorded at their original heads.

@vercel

vercel Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modex Ready Ready Preview Oct 30, 2026 4:52am UTC

Request Review

@github-code-quality

github-code-quality Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage-agent

main a34edc7 canvas-native-ready b0d2395 +/-
66% 66% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated October 30, 2026 05:30 UTC

@BunsDev
BunsDev marked this pull request as ready for review October 30, 2026 04:30
@BunsDev
BunsDev added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit 2ce777c Oct 30, 2026
13 checks passed
@BunsDev
BunsDev deleted the canvas-native-ready branch October 30, 2026 08:44

This branch was successfully deployed

1 active deployment
Preview — b0d23950 Deployed Oct 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant