Repository navigation
test: wait for native Canvas readiness before Escape - #446
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BunsDev
marked this pull request as ready for review
October 30, 2026 04:30
This was referenced Oct 31, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Canvas full-view test could send Escape after React hid the main pane but before the native guest applied full-view bounds. Wait for the visible native Canvas view to match the expanded preview, including zoom and rounding, before sending the existing single Escape. Production behavior and the security, restoration and destruction assertions remain unchanged.
PR #443 failed this assertion in both its initial head run and protected queue run 40992737267. Controlled delayed-IPC diagnostics reproduce the readiness gap; hosted traces do not establish that event ordering conclusively. Both failures and traces are preserved in the linked repository evidence document. No sleep, input retry or timeout increase is added.
Validation: five candidate repetitions passed; build passed; unit checks passed with 2,244 passes and 26 skips. Full local E2E completed with exit 0: 475 desktop passes and seven skips (21.0 minutes), followed by seven site passes (8.3 seconds). The transcript median was 175.7 ms against the approved 500 ms limit. The tested head is
8638fd30a8b2d5e4eafc7fc543126f57bd9f3861, and the worktree remained clean. Source review found no blocking findings. Hosted macOS job123878076309in run 40998793846 passed 478 desktop tests with four skips and seven site tests, with a 382.7 ms transcript median. Protected delivery is pending. Human keyboard and VoiceOver acceptance remain separate; issues #280 and #281 retain their separate acceptance gates.Evidence:
docs/reviews/2026-10-30-canvas-native-readiness.md.Hosted first failures and retry. Windows job
123877826277passed 15 native CLI cases and failed the natural-exit PTY case while waiting for the grandchild heartbeat. One unchanged diagnostic retry with debug logging passed all 16 cases and the full Windows packaging job (123881380189); the cause of the first failure remains unknown. Both logs and digest-verified TAP artifacts are preserved. CodeQL Actions job123877816315failed after SARIF upload began, without a concrete error in its log or annotations; its retry request was rejected with HTTP 403. That failure remains recorded for the original head. The iPhone and required macOS jobs passed. Signed documentation-only commitd1e56c4bc717829606c448f63549b73a62434fcbnow records these results; build and unit checks passed again (2,244 passes, 26 skips, zero failures). Application and test code are unchanged from the fully tested head. The branch now includes main througha34edc75e34c9eaba2b18eccecfeff417b2cd887in signed merge commitb0d239507bdfb1d5f1e88ad88db793998464be87, resolving the status-document conflict while preserving the published release and landed Markdown repair records. Build and unit checks passed on the integrated tree (2,244 passes, 26 skips, zero failures), and all seven site E2E tests passed in 8.5 seconds. The Canvas implementation is unchanged from the fully tested head. All hosted checks passed for integrated headb0d239507bdfb1d5f1e88ad88db793998464be87. macOS job123899056011passed 478 desktop cases with four skips (30.3 minutes) and seven site cases (19.0 seconds), with a 323.5 ms transcript median. Windows, Linux, iPhone and CodeQL checks passed. This exact head was submitted to the protected merge queue without bypass; queue validation and merge remain pending. Earlier failures remain recorded at their original heads.