Repository navigation
docs(code-review): refresh CR-8 matrix to main; CR-6 re-run on Claude 2.1.316; CR-6 smoke and CR-7 canary procedures - #472
Merged
Merged
Conversation
…l on Claude 2.1.316, write the CR-6 smoke and CR-7 canary procedures (#327, #325, #326, #322) - docs/reviews/2026-11-01-cr8-acceptance-matrix.md: every control C01-C82 and every AC of #321-#326 mapped to evidence on main 0a8c513, fixture/authenticated/live/human kept apart, no "not started" rows; staged enablement and rollback; Val's hand-off in one list. - CR-6: unit 223/224 (1 Windows skip) and native denial 6/6 on Claude Code 2.1.316 and codex-cli 0.166.0; live-smoke procedure (not run, needs a repository Val names). - CR-7: correct the stale "Open" notes (merge and decisions 2-4 landed in #416) and record #416's delivery; live-write canary procedure (not run, needs a disposable repository). - VoiceOver checklist: Review with Claude and Merge are built (A4/A5/B3); the seed now puts recorder claude/codex on PATH so the review home never reaches a real login. - status.md: Code Review entries no longer say Gate A is under way. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…d results (#327) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Nov 1, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs and test evidence only. No product code changes. Lane C of the 2026-11-01 goal round: #327, #325, #326, #322.
What changes
docs/reviews/2026-11-01-cr8-acceptance-matrix.md(new, [CR-8][P1] Verify Code Review fidelity, accessibility, recovery and end-to-end safety #327): every control C01–C82 and every AC of [CR-2][P1] Add a main-owned, revision-aware GitHub PR read service #321–[CR-7][P1] Add explicit review actions and head-guarded GitHub merge #326 is mapped to evidence onmain0a8c513.2026-10-28-cr6-native-review.md:-write-submit,-mergeand-pr-actions, which still listed merge and decisions 2–4 as future work;-write-repair, including that the post-merge push run onmainfailed its unit step and was then cancelled;2026-11-01-cr7-live-canary.md. It has not run, because no disposable repository has been named.seed.mjsputs recorderclaude/codexon PATH, so the seeded home can never reach a real login or provider.docs/status.md: the Code Review entries no longer say "Gate A … is under way". They link the refresh, the 2.1.316 re-run and the canary procedure.Evidence (
main0a8c513; Mac17,6 M5 Max, macOS 27.2, Node 24.22.0, Electron 44.4.5, Playwright 1.63.0)MODEX_CR6_NATIVE=1): 6 of 6 passed on Claude 2.1.316 and codex 0.166.0.0a8c513. Its launch line opened the app, and the provider probe reached only the recorder.pnpm build: passed.pnpm test: exit 0, 2,277 passed, 26 skipped, 0 failed.pnpm test:e2e: exit 1: desktop 477 passed, 7 skipped, 1 failed. The failure isapp.spec.ts:729(accessibility), a strict-mode violation with two "Chat details" dialogs, at a load average near 100. It is not a Code Review spec, and it passed 1/1 alone. The chain stopped before the site stage, which passed 7/7 when run separately. This is not a green local full run. The hostedunit + e2e (macOS)check passed onc1f74c7.Not done, waiting on Val: VoiceOver, the R1–R4 references, a repository for the CR-6 smoke, a disposable repository for the CR-7 canary, decisions 1, 5, 6 and 7, and the
modex.codeReviewswitch. Nothing live ran. No GitHub write was made from the app.🤖 Generated with Claude Code