Skip to content

docs(code-review): refresh CR-8 matrix to main; CR-6 re-run on Claude 2.1.316; CR-6 smoke and CR-7 canary procedures - #472

Merged
BunsDev merged 5 commits into
mainfrom
cr-gates-lane-c
Nov 1, 2026
Merged

BunsDev merged 5 commits into
mainfrom
cr-gates-lane-c

Conversation

@BunsDev

@BunsDev BunsDev commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Docs and test evidence only. No product code changes. Lane C of the 2026-11-01 goal round: #327, #325, #326, #322.

What changes

Evidence (main 0a8c513; Mac17,6 M5 Max, macOS 27.2, Node 24.22.0, Electron 44.4.5, Playwright 1.63.0)

  • Code Review unit tests: 224 tests, 223 passed, 1 skipped (Windows only).
  • Native denial (MODEX_CR6_NATIVE=1): 6 of 6 passed on Claude 2.1.316 and codex 0.166.0.
  • Focused E2E (journey, regressions, a11y, measure, agent, actions, navigation, scroll): 51 of 51 passed.
  • VoiceOver seed rebuilt on 0a8c513. Its launch line opened the app, and the provider probe reached only the recorder.
  • pnpm build: passed. pnpm test: exit 0, 2,277 passed, 26 skipped, 0 failed.
  • pnpm test:e2e: exit 1: desktop 477 passed, 7 skipped, 1 failed. The failure is app.spec.ts:729 (accessibility), a strict-mode violation with two "Chat details" dialogs, at a load average near 100. It is not a Code Review spec, and it passed 1/1 alone. The chain stopped before the site stage, which passed 7/7 when run separately. This is not a green local full run. The hosted unit + e2e (macOS) check passed on c1f74c7.

Not done, waiting on Val: VoiceOver, the R1–R4 references, a repository for the CR-6 smoke, a disposable repository for the CR-7 canary, decisions 1, 5, 6 and 7, and the modex.codeReview switch. Nothing live ran. No GitHub write was made from the app.

🤖 Generated with Claude Code

…l on Claude 2.1.316, write the CR-6 smoke and CR-7 canary procedures (#327, #325, #326, #322)

- docs/reviews/2026-11-01-cr8-acceptance-matrix.md: every control C01-C82 and every AC of
  #321-#326 mapped to evidence on main 0a8c513, fixture/authenticated/live/human kept apart,
  no "not started" rows; staged enablement and rollback; Val's hand-off in one list.
- CR-6: unit 223/224 (1 Windows skip) and native denial 6/6 on Claude Code 2.1.316 and
  codex-cli 0.166.0; live-smoke procedure (not run, needs a repository Val names).
- CR-7: correct the stale "Open" notes (merge and decisions 2-4 landed in #416) and record
  #416's delivery; live-write canary procedure (not run, needs a disposable repository).
- VoiceOver checklist: Review with Claude and Merge are built (A4/A5/B3); the seed now puts
  recorder claude/codex on PATH so the review home never reaches a real login.
- status.md: Code Review entries no longer say Gate A is under way.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modex Ready Ready Preview Nov 1, 2026 7:08pm UTC

Request Review

@github-code-quality

github-code-quality Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage-agent

main 66d0031 cr-gates-lane-c 353e971 +/-
66% 66% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated November 01, 2026 19:44 UTC

@BunsDev
BunsDev added this pull request to the merge queue Nov 1, 2026
@BunsDev
BunsDev removed this pull request from the merge queue due to a manual request Nov 1, 2026
BunsDev and others added 2 commits November 1, 2026 07:48
…d results (#327)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@BunsDev
BunsDev added this pull request to the merge queue Nov 1, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 1, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@BunsDev
BunsDev enabled auto-merge November 1, 2026 19:08
@BunsDev
BunsDev added this pull request to the merge queue Nov 1, 2026
Merged via the queue into main with commit 7cfb29c Nov 1, 2026
11 checks passed
@BunsDev
BunsDev deleted the cr-gates-lane-c branch November 1, 2026 20:25

This branch was successfully deployed

1 active deployment
Preview — 353e9711 Deployed Nov 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants