Skip to content

Fix Code Review links after repository rename - #477

Merged
BunsDev merged 2 commits into
mainfrom
cr-pr-locator
Nov 1, 2026
Merged

BunsDev merged 2 commits into
mainfrom
cr-pr-locator

Conversation

@BunsDev

@BunsDev BunsDev commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

When an overview reports a renamed or transferred repository, the PR header and GitHub/copy links now adopt its current locator after the existing account and stable PR-key checks. An unavailable refresh retains the last accepted locator. This addresses C22 in #327 and #323.

Validation: the new Electron regression failed before the fix and passed afterward; independent review found no blockers. Build passed. The full unit retry passed with 2,277 passes and 26 skips. Full E2E passed with 479 desktop tests and 7 skips, followed by 7 site tests. The transcript benchmark median was 113.4 ms against the unchanged 500 ms limit.

The first full attempt failed in the unchanged worktree archive test with a null subprocess exit status under heavy machine load. Its log is preserved; one focused diagnostic retry and then the unchanged canonical unit/E2E retry passed. Resource pressure remains a hypothesis, not a proven cause. Details are in docs/reviews/2026-11-01-cr4-current-locator.md.

Human accessibility, original-reference comparison, and live provider/write acceptance remain open. Fixtures make no live GitHub write or provider call.

Main date-correction integration: 7f5915d5bd0bfd15ef1d249d111ee6a24c3ac11e resolves only two docs/status.md dates against 85d2c001. Application source and E2E tests are unchanged from the fully validated locator candidate. Independent review found no resolution issues, and a fresh pnpm build && pnpm test passed (2,277 passes, 26 skips). Hosted validation on the new head remains pending.

@vercel

vercel Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modex Ready Ready Preview Nov 1, 2026 2:32pm UTC

Request Review

@github-code-quality

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage-agent

main 0a8c513 cr-pr-locator 7f5915d +/-
66% 66% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

@BunsDev
BunsDev added this pull request to the merge queue Nov 1, 2026
Merged via the queue into main with commit 49aa449 Nov 1, 2026
13 checks passed
@BunsDev
BunsDev deleted the cr-pr-locator branch November 1, 2026 16:53
BunsDev added a commit that referenced this pull request Nov 3, 2026
…ection (C61)

CR-6 built Ask inline rather than as the floating composer C61 was planned
for, so clearance was never re-measured. The new test checks Ask and the last
activity item at 900x600 and 1440x900, with the review panel shut and open.
It fails under an overlay and under a panel that takes the pane's height. The
layout needed no change.

Also bring the CR-8 matrix up to date: #477 already closed C22 and D6, and
authenticated GET-only read to Val's session.

Refs #319, #323, #327.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch was successfully deployed

1 active deployment
Preview — 7f5915d5 Deployed Nov 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant