Repository navigation
Add device onboarding CLI - #205
Merged
Merged
Conversation
Owner
Author
Live onboarding resultsRun against both lab configurations with the PR source mounted read-only. Targets: route The lab currently lacks the AS 64999 policy fixtures. Only the FRR core sessions are established. Missing route results are test failures, not successful validation. An independent FRR run using the default BGP targets passed all eight queries.
Configuration checks
The CLI caught empty-table responses that otherwise looked successful. The corrected MikroTik run reports four empty-table failures and four successful ping/traceroute commands. Regression tests cover this result. Complete live-platform acceptance still needs the stopped VMs and the policy fixture feeds. |
WilhelmZA
marked this pull request as ready for review
October 31, 2026 21:34
WilhelmZA
force-pushed
the
feat/onboard-cli-128
branch
from
October 31, 2026 21:38
bc38605 to
2fcbed9
Compare
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #128.
hyperglass onboard device,test,check, anddirective.Verification
Lab limitation
Most configured router VMs are stopped. Most running routers also have their BGP feeds disabled. The policy matrix's AS 64999 fixture routes are absent; its FRR API query returns the existing no-matching-results warning. The CLI reports missing output and empty structured tables as failed tests. This draft remains open for complete live-platform acceptance.