Repository navigation
ktms mcp: drain on shutdown, clean stop, lenient bearer scheme - #111
Merged
Merged
Conversation
The HTTP server lets running calls finish before the Admin API connection closes, and a signal ends a stdio server with exit 0. The bearer scheme is matched without case. The MCP token is checked before the admin key and any call, and --mcp-token-file without --listen is a usage error.
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #110, from the review of the same code in light-tokenmeter (ai-process/light-tokenmeter#24):
serveMCPwaits forhttp.Server.Shutdownbefore returning, so running tool calls finish before the deferred Admin API connection closes.Authorizationscheme matched case-insensitively, surrounding spaces tolerated; still a constant-time token compare.--listentoken is checked before the admin key and any network call;--mcp-token-filewithout--listenis a usage error.