Repository navigation
fix(release): Homebrew tap token as exactly {{ .Env.HOMEBREW_TAP_TOKEN }} - #123
Merged
Merged
Conversation
…N }} GoReleaser accepts a tap token only in that form; the conditional template stopped 1.3.0, and the index form stopped 1.3.1, both right after their GitHub releases. The CHANGELOG now says so.
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.3.1 stopped in the Homebrew step too:
expected {{ .Env.VAR_NAME }} only (no plain-text or other interpolation). GoReleaser applies a tap token withApplySingleEnvOnly, which accepts only^{{\s*\.Env\.NAME\s*}}$and has noisEnvSetin its function map. That map is where 1.3.0's error came from:isEnvSetitself is not Pro-only, so #121's diagnosis was wrong.token: "{{ .Env.HOMEBREW_TAP_TOKEN }}"for both formulas. It is read only on upload, andskip_uploadturns that off when the secret is unset, as in 1.2.0.1.3.0 and 1.3.1 have binaries on GitHub but no images, chart or formulas; 1.3.2 follows in its own release PR.