Fix: Make Image insert screen WebView background transparent - #21823
Open
Ratnesh5 wants to merge 2 commits into
Open
Fix: Make Image insert screen WebView background transparent#21823Ratnesh5 wants to merge 2 commits into
Ratnesh5 wants to merge 2 commits into
Conversation
david-allison
requested changes
Sep 11, 2026
david-allison
left a comment
Member
There was a problem hiding this comment.
Would it be feasible for you to add a @NeedsTest or a screenshot test for this, so we catch future regressions?
Code looks good, thanks!
Contributor
Author
Done! Added the @NeedsTest annotations where the background color is set. Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
By default, the image insert screen's WebView renders with a white background. This caused the background to clash with the app's theme and look glaringly out of place, especially in dark mode.
Fixes
Approach
To address this, we need the
WebViewto have a transparent background so that the underlying app theme's background shows through seamlessly.setBackgroundColor(color: Int)inSafeWebViewLayoutso it applies the color to its internalWebView.multimediaWebViewbackground toColor.TRANSPARENTinMultimediaImageFragmentduringsetupWebView().Below is the attached screenshot of before and after


How Has This Been Tested?
Checklist
Please, go through these checks before submitting the PR.