Skip to content

Fix: Make Image insert screen WebView background transparent #21823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrayanDSO merged 2 commits into from
Sep 12, 2026
+10 −0
Merged

Fix: Make Image insert screen WebView background transparent #21823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
375377b
Fix: Make Image insert screen WebView background transparent
Ratnesh5 Sep 11, 2026
2caaeb5
chore: add @NeedsTest for image insert transparent background
Ratnesh5 Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions AnkiDroid/src/main/java/com/ichi2/anki/multimedia/MultimediaImageFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import android.content.ContentResolver
import android.content.Context
import android.content.Intent
import android.graphics.Bitmap
import android.graphics.Color
import android.graphics.drawable.BitmapDrawable
import android.net.Uri
import android.os.Bundle
Expand Down Expand Up @@ -268,8 +269,10 @@ class MultimediaImageFragment :
setupDoneButton()
}

@NeedsTest("Verify the webview background color is transparent and matches the app theme")
private fun setupWebView() {
binding.multimediaWebView.setWebViewClient(SafeWebViewClient())
binding.multimediaWebView.setBackgroundColor(Color.TRANSPARENT)
}

/**
Expand Down
7 changes: 7 additions & 0 deletions AnkiDroid/src/main/java/com/ichi2/anki/workarounds/SafeWebViewLayout.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import androidx.annotation.MainThread
import androidx.fragment.app.Fragment
import androidx.fragment.app.findFragment
import com.ichi2.anki.BuildConfig
import com.ichi2.anki.common.annotations.NeedsTest
import com.ichi2.anki.common.crashreporting.runCatchingWithReport
import timber.log.Timber

Expand All @@ -45,6 +46,12 @@ open class SafeWebViewLayout :
field = value
}

@NeedsTest("Verify background color applies to inner WebView")
override fun setBackgroundColor(color: Int) {
super.setBackgroundColor(color)
webView.setBackgroundColor(color)
}

protected open fun createWebView() = WebView(context)

init {
Expand Down
Loading