minor : batches_to_flight_data() should not require ownership of arguments - #11010
Open
Rich-T-kid wants to merge 2 commits into
Open
minor : batches_to_flight_data() should not require ownership of arguments #11010Rich-T-kid wants to merge 2 commits into
Rich-T-kid wants to merge 2 commits into
Conversation
github-actions
Bot
added
arrow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
batches_to_flight_data()should not require ownership of arguments #4014Rationale for this change
see #4014
What changes are included in this PR?
change arguments of
batches_to_flight_data()to take in an iterator so that the underlying container (typically a vecotr) does not need to take ownership.Are these changes tested?
n/a
Are there any user-facing changes?
yes, this is a breaking change. but it should be a no-op change for existing users that used
Vec<record_batch>