Repository navigation
Fail DNS apply early with a clear error when Porkbun secrets are empty - #1
Closed
martinbonnin with Copilot wants to merge 2 commits into
Closed
martinbonnin with Copilot wants to merge 2 commits into
martinbonnin with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: martinbonnin <3974977+martinbonnin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job apply
Fail DNS apply early with a clear error when Porkbun secrets are empty
Oct 8, 2026
Copilot stopped work on behalf of
martinbonnin due to an error
October 8, 2026 09:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
applyjob failed with400 API Key Required/APIError: All API requests require an API key or API token.PORKBUN_API_KEYand/orPORKBUN_SECRET_KEYreached the step as empty values, so octoDNS called Porkbun with no credentials. The workflow andconfig/octodns.yamlwiring is correct. The underlying cause is a missing or empty secret, which this PR cannot fix..github/workflows/dns-apply.ymloctoDNS applystep now checks that both env vars are non-empty before runningoctodns-sync.::error::annotation naming the secrets and exits 1. This replaces the Porkbun traceback with a message pointing at the actual problem.Needed before the job can pass: set
PORKBUN_API_KEYandPORKBUN_SECRET_KEYas repo secrets, or as secrets on theproductionenvironment that this job runs in. Also confirm API Access is enabled forapi-standards.ioin Porkbun. Without that, the job will still fail, now with the clearer error.dns-plan.ymlhas the same unguarded step and was left unchanged.