Skip to content

Fail DNS apply early with a clear error when Porkbun secrets are empty #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fail DNS apply early with a clear error when Porkbun secrets are empty #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bf8621
Initial plan
Copilot Oct 8, 2026
7c7f32c
Apply remaining changes
Copilot Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/dns-apply.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,9 @@ jobs:
env:
PORKBUN_API_KEY: ${{ secrets.PORKBUN_API_KEY }}
PORKBUN_SECRET_KEY: ${{ secrets.PORKBUN_SECRET_KEY }}
run: octodns-sync --config-file=config/octodns.yaml --doit
run: |
if [ -z "$PORKBUN_API_KEY" ] || [ -z "$PORKBUN_SECRET_KEY" ]; then
echo "::error::PORKBUN_API_KEY and/or PORKBUN_SECRET_KEY are empty. Add them as secrets on the repository or the 'production' environment."
exit 1
fi
octodns-sync --config-file=config/octodns.yaml --doit