Repository navigation
Keep chart toggle buttons on the legend row - #182
Merged
Merged
Conversation
Toggling a reference line removed its legend row, shrinking the card and moving the toggle button. Render toggles in a footer slot that shares the legend row.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #181
Summary
Toggling a chart's reference line (Trend, Net invested) removed the legend row, so the card shrank and the toggle button jumped up. Toggle buttons now share the legend row, keeping the card height and button position stable.
Changes
footerslot toInteractiveAreaChart, rendered on the legend row (legend left, footer right) and also in privacy-hidden mode.Verification
(cd client && npx tsc -b): passed.npm run lint -w client -- --max-warnings=0: passed.npx vitest run src/components(client): 38 files, 343 tests passed.